-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix functional testing and cached output errors #1334
Fix functional testing and cached output errors #1334
Conversation
The errors we expect to see at this point are 9 test failures for Entra in MS.AAD.7.x related to Get-PrivilegedUser. There is another PR in the works that will resolve those. As for Defender, some of the ones in this run are due to issues with the webdriver timing out. A couple look like actual failures. I will look into those a bit more.
|
Will approve then for these current changes. |
@nanda-katikaneni Ready for merge. |
* Fix Invoke-ScubaCached output location for provider settings.
3d70e0f
to
c8fafff
Compare
Ran another functional test run after rebasing with AAD fixes, and none of the Entra tests fail now. SharePoint is also passing with fixes. Defender individual tests still fail, and I will investigate, although it's possible the concurrency workflow PR may prevent errors there since this branch still runs multiple tests in parallel on the same tenant. Either way, the remaining test issues are not relevant to this particular branches changes. |
🗣 Description
This request contains updates to fix failures when running tests that modify configuration setting export results prior to testing. Specifically this update:
💭 Motivation and context
Some testing requires manual changes to represent uncommon or undesirable test results. Doing so means the functional test harness may intercept and change those results before running a test. The bug was preventing the modified results from being used in the tests and causing tests to fail when they should pass. We want tests to accurately report their results.
Closes #1328
Closes #1329
Closes #1333
Closes #1337
🧪 Testing
To test this PR, either run the nightly functional test pipeline to validate that all tests using cached results (UpdateProviderExport in preconditions) pass as expected, particularly MS.AAD.3.2v1 and MS.AAD.3.3v1 tests. Or run the functional tests using the ScubaGearCheck.ps1 script as follows (note: this is for internal dev use only and requires additional configuration):
ScubaGearCheck.ps1 -Baseline aad -Tenant 2 -UserAuth:$false -Filter "MS.AAD.3.[23]v1*"
All tests should pass.
Also test via:
Create output with merged json using the default invoke options, then run the following:
Invoke-ScubaCached -OutPath .\path-to-output-folder-from-original-run\ -ExportProvider $false
Also, when running functional tests verify that this error is not present in Defender tests:
✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
✅ Post-merge checklist