Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the location argument to Set-Utf8NoBom in Invoke-ScubaCached #1335

Closed
wants to merge 1 commit into from

Conversation

buidav
Copy link
Collaborator

@buidav buidav commented Sep 24, 2024

🗣 Description

  • Provide the correct location argument to Set-Utf8NoBom in Invoke-SCuBACached
  • Days since David has put a bug in the functional tests: 0

💭 Motivation and context

Closes #1329

🧪 Testing

  • From adhilto
  1. Create output with merged json. From the latest on main, this is as easy as Invoke-Scuba
  2. Invoke-ScubaCached -OutPath .\path-to-output-folder-from-step-1\ -ExportProvider $false

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@buidav buidav added the bug This issue or pull request addresses broken functionality label Sep 24, 2024
@buidav buidav added this to the Jellyfish milestone Sep 24, 2024
@buidav buidav linked an issue Sep 24, 2024 that may be closed by this pull request
@buidav buidav self-assigned this Sep 24, 2024
@buidav buidav marked this pull request as ready for review September 24, 2024 23:45
@schrolla
Copy link
Collaborator

schrolla commented Sep 25, 2024

@buidav So I think I actually need this fix as well to get a clean run with #1333. Would it make sense to kill one or the other of our PRs and put both fixes in one since we won't get a clean functional test run unless both fixes are present?

@buidav
Copy link
Collaborator Author

buidav commented Sep 25, 2024

Closing as fix will be merged in #1334

@buidav buidav closed this Sep 25, 2024
@buidav buidav deleted the 1329-bug-with-invoke-scubacached branch September 26, 2024 00:09
@buidav buidav removed this from the Jellyfish milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with Invoke-SCuBACached if no provider json
3 participants