Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Add UUID to the JSON output (both raw provider output and ScubaResults.json).
💭 Motivation and context
Closes #1336.
🧪 Testing
I performed the following tests:
Invoke-Scuba
. Worked as expected.Invoke-Scuba -KeepIndividualJson
. Worked as expected.Invoke-ScubaCached -ExportProvider $false
with input generated without theKeepIndividualJson
flag. Worked as expected.Invoke-ScubaCached -ExportProvider $false
with input generated with theKeepIndividualJson
flag. Worked as expected. (assuming you manually fix Bug with Invoke-SCuBACached if no provider json #1329 as Fix functional testing and cached output errors #1334 hasn't been merged yet).Invoke-ScubaCached -KeepIndividualJson -ExportProvider $false
with input generated without theKeepIndividualJson
flag. Worked as expected.Invoke-ScubaCached -KeepIndividualJson -ExportProvider $false
with input generated with theKeepIndividualJson
flag.Invoke-ScubaCached -ExportProvider $false
with input generated without theKeepIndividualJson
flag and without the "report_uuid" field (to ensure backwards compatibility with output created before this PR). Worked as expected.Invoke-ScubaCached -ExportProvider $false
with input generated with theKeepIndividualJson
flag and without the "report_uuid" field. Worked as expected.Invoke-SCuBACached
. Worked as expected.Invoke-SCuBACached -KeepIndividualJson
. Worked as expected.✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
✅ Post-merge checklist