Remove embedded ClockGen in TestBench #826
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Design
This PR proposes we should try move simulation control logic (clock gen, dump wave, watch dog, etc) to
TestDriver.sv
. These features are inherently coupled with simulation platform. For VCS flow, it's best to address these in verilog code.Current Design:
Proposed Design:Benefits
extensible to Arcilator in the future: I suppose we need a dedicated test driver for arc anyway, it's very unlike to reuse current ClockGen.Future work: I plan do refacoring of simulation control code, the current code is too messy. This is the first step.
UPDATE: After discusssion, we reach consensus that no need to pull inner ClockGen to outer TestDriver. This PR only change inlined ClockGen to ExtModule.