Fix pip breaking file: support.
#73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arnaud Caron <[email protected]>
Fixes chipsalliance#72. Signed-off-by: Tim 'mithro' Ansell <[email protected]>
|
@tcal-x -- This was the fix right? |
|
Yes that's the fix (I found the same fix on symbiflow-examples here: chipsalliance/f4pga-examples@6234464 ). But I don't know what's causing the CI failures. |
It seems like Windows has issues with upgrading the pip/wheel installed via `actions/setup-pyython@v2`. Signed-off-by: Tim 'mithro' Ansell <[email protected]>
Using the `-m` option makes sure we are using the pip that is available inside the environment provided by the Python executable, even if `pip` in the path is setup to use a different Python (for example with a hard-coded `#!/usr/bin/python`). Signed-off-by: Tim 'mithro' Ansell <[email protected]>
|
As the static builds are the only ones failing now (due to antlr parser not working), I've logged #75 and am going to merge these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72.
Signed-off-by: Tim 'mithro' Ansell [email protected]