Skip to content

Commit

Permalink
Merge pull request #73 from mithro/file-fix
Browse files Browse the repository at this point in the history
Fix pip breaking `file:` support.
  • Loading branch information
mithro authored Oct 13, 2021
2 parents 99f199f + 7e6a3e3 commit 3aab631
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 13 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/check-install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,13 @@ jobs:

- name: Install pip+wheel
run: |
pip install --upgrade wheel
pip install --upgrade pip
python -m pip install --user --upgrade wheel
python -m pip install --user --upgrade pip
- name: Test installation
shell: bash
run: |
pip install git+https://github.com/${GITHUB_REPOSITORY}.git@${GITHUB_SHA}#egg=fasm
python -m pip install git+https://github.com/${GITHUB_REPOSITORY}.git@${GITHUB_SHA}#egg=fasm
- name: Run Smoke Test
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
sudo apt update
sudo apt install clang-format
python -m pip install --upgrade pip
pip install -r requirements.txt
python -m pip install -r requirements.txt
- name: Python style check
run: |
make format lint
Expand Down Expand Up @@ -66,7 +66,7 @@ jobs:
sudo apt update
sudo apt install cmake default-jre-headless uuid-dev libantlr4-runtime-dev
python -m pip install --upgrade pip
pip install -r requirements.txt
python -m pip install -r requirements.txt
python update_version.py
- name: Tox
run: ANTLR4_RUNTIME_TYPE=${{ matrix.antlr_runtime_type }} tox -e ${{ matrix.TOXENV }}
12 changes: 6 additions & 6 deletions .github/workflows/publish-to-pypi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ jobs:

- name: Install build dependencies
run: |
pip install -U pip
pip install -r requirements.txt
python -m pip install -U pip
python -m pip install -r requirements.txt
python update_version.py
- name: Install package dependencies
Expand Down Expand Up @@ -89,8 +89,8 @@ jobs:

- name: Install build dependencies
run: |
pip install -U pip
pip install twine auditwheel
python -m pip install -U pip
python -m pip install twine auditwheel
python update_version.py
- name: 🚧 Build distribution 📦
Expand Down Expand Up @@ -181,8 +181,8 @@ jobs:

- name: Install build dependencies
run: |
pip install -U pip
pip install -r requirements.txt
python -m pip install -U pip
python -m pip install -r requirements.txt
python update_version.py
- name: Install package dependencies
Expand Down
2 changes: 1 addition & 1 deletion environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ dependencies:
- python
- swig
- pip:
- -r file:requirements.txt
- -r requirements.txt
2 changes: 1 addition & 1 deletion src/ParseFasm.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ class FasmParserBaseVisitor : public FasmParserVisitor {
virtual Any visitFasmFile(
FasmParser::FasmFileContext* context) override {
for (auto& line : context->fasmLine()) {
std::string str = visit(line);
std::string str = visit(line).as<std::string>();
if (!str.empty()) {
out << str;
if (hex_mode)
Expand Down

0 comments on commit 3aab631

Please sign in to comment.