Deprecate ChiselAnnotation #2819
Conversation
Add a deprecation string that can be used for marking things that are deprecated due to the MLIR-based FIRRTL Compiler (MFC) migration. Do not use this anywhere (yet). Signed-off-by: Schuyler Eldridge <[email protected]>
Signed-off-by: Schuyler Eldridge <[email protected]>
Signed-off-by: Schuyler Eldridge <[email protected]>
Deprecate all EnumAnnotations as these are not supported by the MLIR-based FIRRTL Compiler. These will reappear as enumerated types in FIRRTL in the future. Signed-off-by: Schuyler Eldridge <[email protected]>
Deprecate ChiselAnnotation as custom annotations will not be supported as part of the migration to the MLIR-based FIRRTL Compiler. Signed-off-by: Schuyler Eldridge <[email protected]>
seldridge
force-pushed
the
dev/seldridge/deprecate-ChiselAnnotation
branch
from
9f3b30f to
33e84d6
Compare
Remove usages of ChiselAnnotation from documentation (since this is now deprecated). Signed-off-by: Schuyler Eldridge <[email protected]>
|
I see people using ChiselAnnotation as a quick-and-dirty at-end-of-elaboration callback since you can do arbitrary things in the |
Yeah, people shouldn't be using it this way (I am speaking to myself when I say this... 😂 ). Maybe a post-elaboration hook. An alternative is to have a custom phase / mandatory phase with this hook that can do this. However, I've soured on the stage/phase infra and think we can move towards fixed pipelines once the SFC is out of the picture. Also, I'm less confident about actually deprecating |
seldridge
force-pushed
the
dev/seldridge/deprecate-enumannotations
branch
from
c001f5f to
d8dcfc7
Compare
Deprecate ChiselAnnotation as custom FIRRTL annotations are not supported as part of the migration to the MILR-based FIRRTL Compiler.