Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LMS] cmd_done toggles with each winternitz round #464

Closed
ludwigatlubis opened this issue Mar 14, 2024 · 0 comments · Fixed by #466
Closed

[LMS] cmd_done toggles with each winternitz round #464

ludwigatlubis opened this issue Mar 14, 2024 · 0 comments · Fixed by #466
Assignees
Labels
bug Something isn't working

Comments

@ludwigatlubis
Copy link
Contributor

In line 423 of module sha256 the signal hwif_in.intr_block_rf.notif_internal_intr_r.notif_cmd_done_sts.hwset of the hardware interface is set.
This signal is asserted whenever a sha256_core computation finishes, i.e., core_digest_valid is asserted.

From our understanding this should only be the case for sha computations.
For winternitz computations, this signal should only be raised when the last sha computation is finished,
i.e., when the winternitz computation performs the transition to the idle state.

We wrote an assertion for this and it fails.
You can find the fsdb containing the waveform of the counterexample generated by the formal tool attached.

command_done_issue.fsdb.zip

@ludwigatlubis ludwigatlubis added the bug Something isn't working label Mar 14, 2024
@mojtaba-bisheh mojtaba-bisheh linked a pull request Mar 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants