Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed makehint comparison bug #30

Merged
merged 3 commits into from
Nov 6, 2024
Merged

fixed makehint comparison bug #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
035c1b5
fixed makehint comparison bug
Nov 6, 2024
c89b306
MICROSOFT AUTOMATED PIPELINE: Stamp 'user/dev/ekarabulut/hintgen_bug_…
Nov 6, 2024
8dc0d79
Merge branch 'main' into user/dev/ekarabulut/hintgen_bug_fix
Nitsirks Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflow_metadata/pr_hash
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
7bfb4b4d33776b47d643ff671de8c7b21ed7a289b58ae5ae0b7424769a2be26bf1525ceb265ad5c170fd43d748d10918
0498b952cc0e6254259daf7a40977490ef109005599f452d7c850f0399d1d571c41792c8008c4147c6cbbe088b49c43c
2 changes: 1 addition & 1 deletion .github/workflow_metadata/pr_timestamp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1730833805
1730913274
4 changes: 2 additions & 2 deletions src/makehint/rtl/hintgen.sv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ module hintgen
assign h = (enable & ~zeroize) ? or2_res : 'b0;

always_comb begin
r_lt_gamma2 = (r <= MLDSA_GAMMA2) ? 1'b1 : 1'b0;
r_gt_q_minus_gamma2 = (r > Q_MINUS_GAMMA2) ? 1'b1 : 1'b0;
r_lt_gamma2 = (r <= MLDSA_GAMMA2) ? 1'b1 : 1'b0;
r_gt_q_minus_gamma2 = (r >= Q_MINUS_GAMMA2) ? 1'b1 : 1'b0;
r_eq_q_minus_gamma2 = (r == Q_MINUS_GAMMA2) ? 1'b1 : 1'b0;
end

Expand Down
3 changes: 0 additions & 3 deletions src/makehint/rtl/makehint.sv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,6 @@ module makehint
//Read fsm
mh_read_state_e read_fsm_state_ps, read_fsm_state_ns;
logic arc_MH_IDLE_MH_RD_MEM;
logic arc_MH_RD_MEM_MH_IDLE;
logic arc_MH_RD_MEM_MH_FLUSH_SBUF;
logic arc_MH_RD_MEM_MH_WAIT1;
logic arc_MH_WAIT2_MH_IDLE;
// logic arc_MH_WAIT_MH_RD_MEM; //TODO don't need wait if we do all polys back to back? check this later
Expand All @@ -108,7 +106,6 @@ module makehint
//Hint sum
logic [7:0] hintsum;
logic busy_reg;
logic incr_reg_wr_addr;
logic latch_hintsum_addr;

//Busy flag
Expand Down