Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed makehint comparison bug #30

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Conversation

ekarabu
Copy link
Collaborator

@ekarabu ekarabu commented Nov 6, 2024

Fixed the bug that is due to the not_res flag, r == -GAMMA2 condition will always generate a non-zero hint and we completely bypass the and_res flag.

Removed unused signals in makehint to prevent Xs in the waveform

…fix' with updated timestamp and hash after successful run
Nitsirks
Nitsirks previously approved these changes Nov 6, 2024
@Nitsirks Nitsirks merged commit 1e2767f into main Nov 6, 2024
5 checks passed
@Nitsirks Nitsirks deleted the user/dev/ekarabulut/hintgen_bug_fix branch November 11, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants