Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

activate Checkstyle and sevntu checks over sonar-checkstyle repository #45

Closed
romani opened this issue Dec 18, 2016 · 3 comments
Closed

activate Checkstyle and sevntu checks over sonar-checkstyle repository #45

romani opened this issue Dec 18, 2016 · 3 comments
Labels
approved
Milestone
4.28

Comments

@romani
Copy link
Member

romani commented Dec 18, 2016

set of rules could be taken from checkstyle repo.
romani added a commit that referenced this issue Dec 24, 2016
@romani
Issue #45: checkstyle config was created, but all violations are supp…
df04cbf 
…ressed for now
romani added a commit that referenced this issue Dec 24, 2016
@romani
Issue #45: sevntu checks are activated but all violations are suppressed
2ad593c
romani added a commit that referenced this issue Dec 24, 2016
@romani
Issue #45: sevntu repo was added
3f1ece0
romani added a commit that referenced this issue Dec 25, 2016
@romani
Issue #45: move all configs to config folder
ed6d76d
romani added a commit that referenced this issue Dec 25, 2016
@romani
Issue #45: split suppressions for main code
8c597d1
romani added a commit that referenced this issue Dec 25, 2016
@romani
Issue #45: split suppressions for tests
ac8b4b7
romani added a commit that referenced this issue Dec 25, 2016
@romani
Issue #45: ImportOrder is resolved
038753b
romani added a commit that referenced this issue Dec 25, 2016
@romani
Issue #45: resolve AvoidInlineConditionals violations
cc915b2
romani added a commit that referenced this issue Dec 25, 2016
@romani
Issue #45: resolve MultipleStringLiterals violations
882df6f
romani added a commit that referenced this issue Dec 25, 2016
@romani
Issue #45: resolve AbbreviationAsWordInName violations
60efc53
romani added a commit that referenced this issue Dec 27, 2016
@romani
Issue #45: resolve LineLength issues in tests
6039316
romani added a commit that referenced this issue Dec 28, 2016
@romani
Issue #45: LineLenght violations are resolved in main code
b3d788e
@rnveach rnveach mentioned this issue Feb 14, 2017
Merged
romani pushed a commit that referenced this issue Feb 14, 2017
@rnveach @romani
Issue #45: resolved multiple simple formatting violations
078a2b2
@rnveach rnveach mentioned this issue Feb 14, 2017
Merged
romani pushed a commit that referenced this issue Feb 14, 2017
@rnveach @romani
Issue #45: resolved many checkstyle violations
b192567
@rnveach
Copy link
Member

rnveach commented Feb 14, 2017 •
edited
Loading

@romani A lot of the violations have been fixed, but I can't do more without spending time and diving into the code for Javadocs, illegal catches, and import control.

@romani romani added the approved label Mar 8, 2019
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani @tsjensen
Issue checkstyle#45: checkstyle config was created, but all violation…
15df6ca 
…s are suppressed for now
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani @tsjensen
Issue checkstyle#45: sevntu checks are activated but all violations a…
ab32ac5 
…re suppressed
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani @tsjensen
Issue checkstyle#45: sevntu repo was added
c70e888
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani @tsjensen
Issue checkstyle#45: move all configs to config folder
4134419
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani @tsjensen
Issue checkstyle#45: split suppressions for main code
9095a9e
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani @tsjensen
Issue checkstyle#45: split suppressions for tests
a3a282c
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani @tsjensen
Issue checkstyle#45: ImportOrder is resolved
5fa5578
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani @tsjensen
Issue checkstyle#45: resolve AvoidInlineConditionals violations
c844e3b
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani @tsjensen
Issue checkstyle#45: resolve MultipleStringLiterals violations
eaf47ff
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani @tsjensen
Issue checkstyle#45: resolve AbbreviationAsWordInName violations
d6d732d
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani @tsjensen
Issue checkstyle#45: resolve LineLength issues in tests
77b35f1
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani @tsjensen
Issue checkstyle#45: LineLenght violations are resolved in main code
d8d4760
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@rnveach @tsjensen
Issue checkstyle#45: resolved multiple simple formatting violations
1e05854
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@rnveach @tsjensen
Issue checkstyle#45: resolved many checkstyle violations
ec6fd6f
@muhlba91
Copy link
Contributor

@romani what's the status of this? i somehow see #217 as a follow up?

@romani
Copy link
Member Author

romani commented Jan 22, 2020

Checkstyle is activated to keep code on leash.
Sevntu Checks can be applied in separate issue

@romani romani closed this as completed Jan 22, 2020
@romani romani added this to the 4.28 milestone Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
4.28
Development

No branches or pull requests
3 participants
@muhlba91 @romani @rnveach