Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #45: resolved many checkstyle violations #74

Merged
merged 1 commit into from
Feb 14, 2017

Conversation

rnveach
Copy link
Member

@rnveach rnveach commented Feb 14, 2017

Issue #45

@rnveach
Copy link
Member Author

rnveach commented Feb 14, 2017

I thought I could fix one catch Exception, but it turns out the test was looking for an NPE so I reverted it.

Failed tests: 
  CheckstyleExecutorTest.executeException 
Expected: (an instance of java.lang.IllegalStateException and exception with message a string containing "Can not execute Checkstyle")
     but: an instance of java.lang.IllegalStateException <java.lang.NullPointerException> is a java.lang.NullPointerException

Stacktrace was: java.lang.NullPointerException
	at com.puppycrawl.tools.checkstyle.Checker.fireAuditStarted(Checker.java:252)
	at com.puppycrawl.tools.checkstyle.Checker.process(Checker.java:206)
	at org.sonar.plugins.checkstyle.CheckstyleExecutor.executeWithClassLoader(CheckstyleExecutor.java:101)
	at org.sonar.plugins.checkstyle.CheckstyleExecutor.execute(CheckstyleExecutor.java:73)
	at org.sonar.plugins.checkstyle.CheckstyleExecutorTest.executeException(CheckstyleExecutorTest.java:95)

@romani romani merged commit b192567 into checkstyle:master Feb 14, 2017
@rnveach rnveach deleted the issue_45_2 branch February 14, 2017 14:12
@romani
Copy link
Member

romani commented Feb 14, 2017

Test should be changed. NPE should not be expected in any code. NPE is clear sign of unexpected situation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants