Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #45: resolved multiple simple formatting violations #73

Merged
merged 3 commits into from
Feb 14, 2017

Conversation

rnveach
Copy link
Member

@rnveach rnveach commented Feb 14, 2017

Issue #45 and Issue #60

Mostly just ran eclipse cs' formatter and fixed minor things resulting from any issues it made. Split this off from any of the others as they will probably be more involved.
Did apply the header to all Java files as it was a simple copy/paste.

@romani
Copy link
Member

romani commented Feb 14, 2017

please make special header file that is for checkstyle but for LGPL v3.
in main project we have LGPL v2. Sonar team is not ok to downgrade licensing, they did this on good reason.

I updated #60 with reply from Sonarqube.

@rnveach
Copy link
Member Author

rnveach commented Feb 14, 2017

@romani I changed the standard header text from '2.1' to '3'. If something more is needed, please let me know.

@romani romani merged commit 078a2b2 into checkstyle:master Feb 14, 2017
@rnveach rnveach deleted the issue_45_1 branch February 14, 2017 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants