Issue #45: sevntu checks are activated but all violations are suppressed

checkstyle · Dec 24, 2016 · 2ad593c · 2ad593c
1 parent df04cbf
commit 2ad593c
Show file tree

Hide file tree

Showing 2 changed files with 54 additions and 0 deletions.
diff --git a/checkstyle-sonar-plugin/config/sevntu_suppressions.xml b/checkstyle-sonar-plugin/config/sevntu_suppressions.xml
@@ -0,0 +1,14 @@
+<?xml version="1.0"?>
+
+<!DOCTYPE suppressions PUBLIC
+    "-//Puppy Crawl//DTD Suppressions 1.1//EN"
+    "http://www.puppycrawl.com/dtds/suppressions_1_1.dtd">
+
+<suppressions>
+    <!-- START of legacy code, all violations will be resolved during transition to main project -->
+    <suppress checks=".*" files=".*[\\/]src[\\/]main[\\/]"/>
+    <suppress checks=".*" files=".*[\\/]src[\\/]test[\\/]"/>
+    <!-- END of legacy code -->
+
+
+</suppressions>
diff --git a/checkstyle-sonar-plugin/pom.xml b/checkstyle-sonar-plugin/pom.xml
@@ -17,6 +17,7 @@
   <properties>
     <checkstyle.version>7.3</checkstyle.version>
     <checkstyle.plugin.version>2.17</checkstyle.plugin.version>
+    <maven.sevntu.checkstyle.plugin.version>1.23.0</maven.sevntu.checkstyle.plugin.version>
   </properties>
 
   <dependencies>
@@ -157,6 +158,45 @@
           </execution>
         </executions>
       </plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-checkstyle-plugin</artifactId>
+        <version>${checkstyle.plugin.version}</version>
+        <dependencies>
+          <dependency>
+            <groupId>com.github.sevntu.checkstyle</groupId>
+            <artifactId>sevntu-checkstyle-maven-plugin</artifactId>
+            <version>${maven.sevntu.checkstyle.plugin.version}</version>
+          </dependency>
+          <dependency>
+            <groupId>com.puppycrawl.tools</groupId>
+            <artifactId>checkstyle</artifactId>
+            <version>${checkstyle.version}</version>
+          </dependency>
+        </dependencies>
+        <!-- Specifying configuration here will take effect on the execution of "mvn checkstyle:checkstyle",
+             but will not take effect on the execution of "mvn site"  -->
+        <configuration>
+          <configLocation>https://raw.githubusercontent.com/checkstyle/checkstyle/checkstyle-${checkstyle.version}/config/checkstyle_sevntu_checks.xml</configLocation>
+          <failOnViolation>true</failOnViolation>
+          <includeResources>false</includeResources>
+          <includeTestResources>false</includeTestResources>
+          <logViolationsToConsole>true</logViolationsToConsole>
+          <maxAllowedViolations>0</maxAllowedViolations>
+          <violationSeverity>error</violationSeverity>
+          <propertyExpansion>project.basedir=${project.basedir}</propertyExpansion>
+          <sourceDirectory>${project.basedir}/src</sourceDirectory>
+        </configuration>
+        <executions>
+          <execution>
+            <id>sevntu-checkstyle-check</id>
+            <phase>verify</phase>
+            <goals>
+              <goal>check</goal>
+            </goals>
+          </execution>
+        </executions>
+      </plugin>
       <plugin>
         <groupId>org.sonarsource.sonar-packaging-maven-plugin</groupId>
         <artifactId>sonar-packaging-maven-plugin</artifactId>