Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for null for tiltseries quality #217

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

daniel-ji
Copy link
Contributor

@daniel-ji daniel-ji commented Aug 23, 2024

we now will show null (unrated) scores instead of 4 for those with tomograms in the gjensen dataset

but to give context, we want alignment data to be surfaced along with these unrated values, so currently blocked until alignment work is complete (confirm with utz / manasa / anchi)

things i updated:

  • db sql schema (a migration script)
  • gjensen config script (and reran it to update files) (None values instead of 4)
  • test infra sql schema
  • schema/core/ yaml

what am i missing?

things to do:

  • run ingestion on all the updated metadata (and sync to staging db, then to prod (s3 and db))
  • run database migration to actually update db sql schema
  • how do we reflect changes on frontend? display null values as "unrated"?

@daniel-ji daniel-ji marked this pull request as draft August 23, 2024 00:27
@daniel-ji daniel-ji marked this pull request as ready for review August 23, 2024 01:25
@daniel-ji daniel-ji marked this pull request as draft August 23, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant