Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreviewed tomograms should not have a quality score by default #948

Open
kandarpksk opened this issue Jul 25, 2024 · 3 comments
Open

Unreviewed tomograms should not have a quality score by default #948

kandarpksk opened this issue Jul 25, 2024 · 3 comments

Comments

@kandarpksk
Copy link
Collaborator

Based on a discussion of feedback form responses, when the quality of a tomogram is not reviewed, the quality score should appear as unrated (tentative language) rather than defaulting to any value (currently rating of 4 I believe).

@junxini junxini added the bug Something isn't working label Aug 1, 2024
@junxini
Copy link
Contributor

junxini commented Aug 1, 2024

@uermel i think the primary action is on the data updates for this. could you take a look when you're back?

@junxini junxini added the severity - medium May interrupt the Portal, causing it to behave in a less than optimal way (e.g., broken link, typo) label Aug 7, 2024
@junxini junxini added frontend and removed bug Something isn't working severity - medium May interrupt the Portal, causing it to behave in a less than optimal way (e.g., broken link, typo) labels Aug 23, 2024
@daniel-ji
Copy link
Contributor

daniel-ji commented Aug 23, 2024

Update (via discussion with @uermel, @anchi2c, @manasaV3):

In addition to the current 1-5 values permitted for tiltseries quality, null is another value that should be accepted by the backend and displayed on the frontend as unrated (not set in stone, cc: @uermel @junxini).

See chanzuckerberg/cryoet-data-portal-backend#217 for the backend changes.

@daniel-ji
Copy link
Contributor

Note this is currently blocked, waiting for alignment data to get surfaced so that null values have more context, see the backend PR (listed above)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants