chore(das/worker): rename log verb to be clear that not all headers are sampled #3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramin
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
walldiss
as code owners
renaynay
reviewed
Feb 28, 2024
| @@ -86,7 +86,7 @@ func (w *worker) run(ctx context.Context, timeout time.Duration, resultCh chan<- | |||
|
|
|||
| if w.state.jobType != recentJob { | |||
| log.Infow( | |||
| "finished sampling headers", | |||
| "finished receiving headers", | |||
There was a problem hiding this comment.
I think this would cause more confusion - "recency" in the context of DASer is related to whether or not a header coming in is a new networkHead (a header being gossiped). Headers that are !recent can still be sampled as long as they are > the sampling window cutoff.
|
so is it not sampling headers older than 30 days, and the logs are misleading? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3194 by suggesting we change the log message from "sampling" to "receiving". Other option could be "evaluating"? Somethign else?