Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

das: Better metric for showing sampled range now that SamplingWindow is enabled #3201

Open
renaynay opened this issue Feb 22, 2024 · 5 comments
Assignees
Labels
area:das Related to DASer enhancement New feature or request

Comments

@renaynay
Copy link
Member

renaynay commented Feb 22, 2024

Right now, sampled chain head refers to the tip of the sampled chain which, while accurate, does not reflect that the light node may not have sampled everything before the SamplingWindow.

There should be some sort of metric that reflects where the light node began sampling potentially - or some way to know whether a light node has actually triggered a sampling job over block at height N.

Needs to be fleshed out a bit more.

(from discussions with @jcstein)

@renaynay renaynay added enhancement New feature or request area:das Related to DASer labels Feb 22, 2024
@jcstein
Copy link
Member

jcstein commented Feb 26, 2024

I think #3196 should accomplish part of this, but may be wrong. cc @ramin

@ramin
Copy link
Contributor

ramin commented Feb 27, 2024

@jcstein this wont quite be solved by #3196, this is issue is regarding telemetry of metrics we'd instrument in the code and which node operators could optionally collect and visualize to show metrics about the operation of a running node

@renaynay
Copy link
Member Author

Now that #3194 is resolved, this one needs to be as well.

@walldiss
Copy link
Member

walldiss commented May 15, 2024

It should instead be a metric on the pruner. DASer is unaware of where or whether the latest pruned height is. In fact, it already exists as prnr_last_pruned (the pruner's highest pruned height). Therefore, the range of stored samples can be easily determined between the DASer head and this metric.

@renaynay
Copy link
Member Author

renaynay commented Dec 2, 2024

@walldiss we have metrics on pruner (prune head) so does this resolve the issue here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:das Related to DASer enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants