Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(das/worker): rename log verb to be clear that not all headers are sampled #3196

Closed
wants to merge 2 commits into from
Closed

chore(das/worker): rename log verb to be clear that not all headers are sampled #3196

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70fe453
rename log to fix #3194
ramin Feb 20, 2024
84d8fcb
Merge branch 'main' into bug/ramin/clearer-logs
ramin Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion das/worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ func (w *worker) run(ctx context.Context, timeout time.Duration, resultCh chan<-

if w.state.jobType != recentJob {
log.Infow(
"finished sampling headers",
"finished receiving headers",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would cause more confusion - "recency" in the context of DASer is related to whether or not a header coming in is a new networkHead (a header being gossiped). Headers that are !recent can still be sampled as long as they are > the sampling window cutoff.

"type", w.state.jobType,
"from", w.state.from,
"to", w.state.curr,
Expand Down
Loading