Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: logs are misleading and node appears to sample old headers #3194

Closed
jcstein opened this issue Feb 20, 2024 · 1 comment · Fixed by #3380
Closed

bug: logs are misleading and node appears to sample old headers #3194

jcstein opened this issue Feb 20, 2024 · 1 comment · Fixed by #3380
Assignees
@ramin @renaynay
Labels
area:das Related to DASer area:metrics Related to measuring/collecting node metrics external Issues created by non node team members

Comments

@jcstein
Copy link
Member

jcstein commented Feb 20, 2024

Celestia Node version

v0.13.0

OS

macOS

Install tools

docs

Others

No response

Steps to reproduce it

run a light node

Expected result

it doesn't sample further than 30 days back, per release notes: "This release introduces a light node sampling window of 30 days, specified in CIP-4. Light nodes will now only sample blocks within a 30 day window instead of sampling all blocks from genesis."

Actual result

logs are misleading because it looks like it is still sampling further than 30 days back?

2024-02-19T20:05:46.307+0100	INFO	das	das/worker.go:88	finished sampling headers	{"type": "catchup", "from": 815902, "to": 816001, "errors": 0, "finished (s)": 13.106756458}

Relevant log output

No response

Notes

No response
@jcstein jcstein added the bug Something isn't working label Feb 20, 2024
@jcstein jcstein changed the title bug: logs are misleading bug: logs are misleading and node appears to sample old heades Feb 20, 2024
@github-actions github-actions bot added the external Issues created by non node team members label Feb 20, 2024
@jcstein jcstein changed the title bug: logs are misleading and node appears to sample old heades bug: logs are misleading and node appears to sample old headers Feb 20, 2024
ramin added a commit that referenced this issue Feb 20, 2024
@ramin
rename log to fix #3194
70fe453
@ramin ramin mentioned this issue Feb 20, 2024
Closed
@ramin ramin self-assigned this Feb 25, 2024
@ramin ramin removed the bug Something isn't working label Feb 25, 2024
@renaynay renaynay added area:das Related to DASer area:metrics Related to measuring/collecting node metrics labels Mar 1, 2024
This was referenced May 8, 2024
Merged
Open
renaynay added a commit that referenced this issue May 15, 2024
@renaynay
fix(das): Clarify logs for historic headers that are skipped (#3380)
3ca66ea 
Fix is kind of ugly but there needs to be a way to bubble up to worker
that the header is skipped vs being sampled successfully.

Resolves #3194
Wondertan pushed a commit that referenced this issue May 20, 2024
@renaynay @Wondertan
fix(das): Clarify logs for historic headers that are skipped (#3380)
e40a109 
Fix is kind of ugly but there needs to be a way to bubble up to worker
that the header is skipped vs being sampled successfully.

Resolves #3194
@jcstein
Copy link
Member Author

jcstein commented Jun 24, 2024

nice :)

2024-06-24T12:46:36.524-0400 INFO das das/worker.go:94 finished sampling headers {"type": "catchup", "from": 16402, "to": 16501, "errors": 0, "# of headers skipped as outside of sampling window": 100, "finished (s)": 5.959832375}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ramin ramin

@renaynay renaynay

Labels
area:das Related to DASer area:metrics Related to measuring/collecting node metrics external Issues created by non node team members
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(das): Clarify logs for historic headers that are skipped renaynay/celestia-node
3 participants
@ramin @renaynay @jcstein