fix(das): Clarify logs for historic headers that are skipped #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
requested review from
Wondertan,
vgonkivs,
distractedm1nd,
walldiss and
ramin
as code owners
ramin
approved these changes
May 9, 2024
walldiss
approved these changes
May 13, 2024
jcstein
reviewed
May 16, 2024
| // errOutsideSamplingWindow is an error used to inform | ||
| // the caller of Sample that the given header is outside | ||
| // the sampling window. | ||
| var errOutsideSamplingWindow = fmt.Errorf("skipping header outside of sampling window") |
Wondertan
pushed a commit
that referenced
this pull request
May 20, 2024
Fix is kind of ugly but there needs to be a way to bubble up to worker that the header is skipped vs being sampled successfully. Resolves #3194
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix is kind of ugly but there needs to be a way to bubble up to worker that the header is skipped vs being sampled successfully.
Resolves #3194