Specify a reviewer for git ubuntu submit #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryceharrington
requested changes
Jan 9, 2025
There was a problem hiding this comment.
One phrasing suggestion, to suggest some example teams (which I took from 2 teams currently represented in the ubuntu server team's active reviews page). Rest LGTM.
The last paragraph about defaulting to ubuntu-server, will go away once git-ubuntu is fixed but until then it's fine to include this text. Hopefully we can drop it before too long.
Users learning how to submit MPs through git ubuntu will often send their MPs to the server team to review due to the current git-ubuntu default reviewer value. While this default value is not revisited, let's ensure random MPs will not land in the server team queue by instructing users to explicitly add ubuntu-sponsors (or something else) as reviewers for their MPs. Signed-off-by: Athos Ribeiro <[email protected]>
athos-ribeiro
force-pushed
the
git-ubuntu-reviewer
branch
from
12f90f7 to
125c8d8
Compare
|
Thanks, @bryceharrington Fixed as suggested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users learning how to submit MPs through git ubuntu will often send their MPs to the server team to review due to the current git-ubuntu default reviewer value. While this default value is not revisited, let's ensure random MPs will not land in the server team queue by instructing users to explicitly add ubuntu-sponsors (or something else) as reviewers for their MPs.