Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify a reviewer for git ubuntu submit #150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Specify a reviewer for git ubuntu submit #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion PackageMerging.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1021,11 +1021,24 @@ $ echo "echo abc >test.txt" | at now + 1 minute && sleep 1m && cat test.txt && r
> Git branches with `%` in name don't work. Use something like `_`.

```bash
$ git ubuntu submit --target-branch debian/sid
$ git ubuntu submit --reviewer $REVIEWER --target-branch debian/sid
Your merge proposal is now available at: https://code.launchpad.net/~kstenerud/ubuntu/+source/at/+git/at/+merge/358655
If it looks OK, please move it to the 'Needs Review' state.
```

Where `$REVIEWER` is the team (or user) on Launchpad that you need to look at
your change, for instance `canonical-foundations`, `canonical-public-cloud`, or
similar.

**If you do not have upload rights for this package, use `ubuntu-sponsors`
here.** This will add your Merge Proposal to the [Ubuntu sponsoring
queue](http://sponsoring-reports.ubuntu.com/general.html) so people with upload
rights for that package may eventually review it for you.

Omitting the `--reviewer` field will request a review from the Ubuntu Server
team. If you are unsure if your package should be reviewed by the Server team,
please send it to the sponsoring queue instead (as described above).

* Using a target branch of `debian/sid` may seem wrong, but is a workaround
for LP: #1976112

Expand Down