Skip to content

Commit

Permalink
Specify a reviewer for git ubuntu submit
Browse files Browse the repository at this point in the history
Users learning how to submit MPs through git ubuntu will often send
their MPs to the server team to review due to the current git-ubuntu
default reviewer value. While this default value is not revisited, let's
ensure random MPs will not land in the server team queue by instructing
users to explicitly add ubuntu-sponsors (or something else) as reviewers
for their MPs.

Signed-off-by: Athos Ribeiro <[email protected]>
  • Loading branch information
athos-ribeiro committed Jan 9, 2025
1 parent 3c2f424 commit 125c8d8
Showing 1 changed file with 14 additions and 1 deletion.
15 changes: 14 additions & 1 deletion PackageMerging.md
Original file line number Diff line number Diff line change
Expand Up @@ -1021,11 +1021,24 @@ $ echo "echo abc >test.txt" | at now + 1 minute && sleep 1m && cat test.txt && r
> Git branches with `%` in name don't work. Use something like `_`.
```bash
$ git ubuntu submit --target-branch debian/sid
$ git ubuntu submit --reviewer $REVIEWER --target-branch debian/sid
Your merge proposal is now available at: https://code.launchpad.net/~kstenerud/ubuntu/+source/at/+git/at/+merge/358655
If it looks OK, please move it to the 'Needs Review' state.
```

Where `$REVIEWER` is the team (or user) on Launchpad that you need to look at
your change, for instance `canonical-foundations`, `canonical-public-cloud`, or
similar.

**If you do not have upload rights for this package, use `ubuntu-sponsors`
here.** This will add your Merge Proposal to the [Ubuntu sponsoring
queue](http://sponsoring-reports.ubuntu.com/general.html) so people with upload
rights for that package may eventually review it for you.

Omitting the `--reviewer` field will request a review from the Ubuntu Server
team. If you are unsure if your package should be reviewed by the Server team,
please send it to the sponsoring queue instead (as described above).

* Using a target branch of `debian/sid` may seem wrong, but is a workaround
for LP: #1976112

Expand Down

0 comments on commit 125c8d8

Please sign in to comment.