Refactor #44
Refactor #44
Conversation
carlcsaposs-canonical
force-pushed
the
refactor
branch
3 times, most recently
from
75bfa51 to
dac0cfb
Compare
carlcsaposs-canonical
force-pushed
the
refactor
branch
from
7f4ab92 to
567e981
Compare
There was a problem hiding this comment.
- THANK YOU!
- I like the new mysql-router VM behavior and the synced codebase with K8s.
- I do not like lack of unit tests here and reported you in private one noticed issue.
- are we planning to merge VM and K8s Git repos?
@paulomach @shayancanonical please share you vision here. Tnx!
| @@ -81,7 +82,8 @@ jobs: | |||
| name: ${{ matrix.tox-environments }} | ${{ matrix.ubuntu-versions.series }} | |||
| needs: | |||
| - lint | |||
| - unit-test | |||
| # TODO: re-enable after adding unit tests | |||
There was a problem hiding this comment.
Just to be sure, please drop a ticket to the next pulse / we need to invest here ASAP.
There was a problem hiding this comment.
I've had an open ticket for some time, although the time estimate will likely increase after re-implementing the legacy interface (if we want to unit test the legacy interface)
| # Workaround: Subordinate charms are required to have at least one `requires` endpoint with | ||
| # `scope: container` |
There was a problem hiding this comment.
mysql_client interface already has scope: container.
JFYI, @dragomirp has scheduled a talk with Juju team about juju-info. Carl, consider to join us.
There was a problem hiding this comment.
mysql_client interface already has scope: container.
Yes, but that's not enough
Leftover from #44
Leftover from #44
Ported from canonical/mysql-router-k8s-operator#117 Leftover from #44
Ported from canonical/mysql-router-k8s-operator#117 Leftover from #44
DPE-1854, DPE-1910
Ported from canonical/mysql-router-k8s-operator#51
Changes from kubernetes PR:
Will re-implement legacy interface in separate PR