generated from canonical/template-operator
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor #44
Merged
Merged
Refactor #44
Changes from all commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
25ee95d
Update libs & clear src
carlcsaposs-canonical 0dfee4a
Copy /src/ from k8s charm
carlcsaposs-canonical f3908a7
Update lint ignore
carlcsaposs-canonical c2b59d3
Remove TLS
carlcsaposs-canonical ba4b08f
Remove pod restart handling
carlcsaposs-canonical 9b51fdc
temp disable lint
carlcsaposs-canonical 567e981
temp
carlcsaposs-canonical f94160a
Fix recursion error
carlcsaposs-canonical fcdb675
temp fix for /tmp path in snap
carlcsaposs-canonical f90b96e
fix arg
carlcsaposs-canonical 8e8654c
add relative_to_container method to Path
carlcsaposs-canonical 5f04da2
cast to purepath before getting relative path
carlcsaposs-canonical 7af5af2
fix path
carlcsaposs-canonical aadadbc
fix username
carlcsaposs-canonical 473d7f8
change username
carlcsaposs-canonical d1362eb
fix
carlcsaposs-canonical 3a6c42b
fix socket path
carlcsaposs-canonical 6d077e4
remove username
carlcsaposs-canonical 2558aae
remove installer
carlcsaposs-canonical 6d8ab1c
sync
carlcsaposs-canonical 27ea0de
sync & socket endpoints
carlcsaposs-canonical 4f47eea
/run instead of /var/run
carlcsaposs-canonical fb8e840
Add missing_ok to unlink()
carlcsaposs-canonical 9ce5d19
remove comment
carlcsaposs-canonical b039fad
Add docstring to _update_configured_socket_file_locations()
carlcsaposs-canonical dd433b0
docstring sync
carlcsaposs-canonical 21c11bc
tls todo
carlcsaposs-canonical ff2681b
update snap
carlcsaposs-canonical 6ad2756
sync add attributes before enable
carlcsaposs-canonical 97f74c3
add installer to container
carlcsaposs-canonical 15ad29a
Add abstract_charm.py
carlcsaposs-canonical bbd5497
update metadata.yaml, format
carlcsaposs-canonical d507f2c
remove pytest-order from integration tests
carlcsaposs-canonical 46de3fc
don't use staticmethod for _on_remove
carlcsaposs-canonical b17ee86
remove unused snap revision var
carlcsaposs-canonical fb4cfe2
chown directories
carlcsaposs-canonical f7a3399
update docstring
carlcsaposs-canonical 8f589e3
lint
carlcsaposs-canonical 2297e09
subordinate in class name
carlcsaposs-canonical c8132ea
bind address localhost (socket)
carlcsaposs-canonical e384b52
logger
carlcsaposs-canonical 15633f6
private constant
carlcsaposs-canonical eefb542
rename var
carlcsaposs-canonical 61ad7e5
type annotation
carlcsaposs-canonical 42f4429
set workload version
carlcsaposs-canonical a23bc2f
use pathlib to read file
carlcsaposs-canonical 3c62bc1
update docstring
carlcsaposs-canonical 6d7c0df
store string in var
carlcsaposs-canonical b9dab7d
add logging
carlcsaposs-canonical 65bb445
Update snap revision
carlcsaposs-canonical 6293698
format
carlcsaposs-canonical 1dc4481
add todo comment
carlcsaposs-canonical 3650fdd
add missing limit to backend-database endpoint
carlcsaposs-canonical eb1ec2c
remove installer class
carlcsaposs-canonical 12a58a8
Fix type annotation for python 3.8 compatability
carlcsaposs-canonical 7855afa
Remove SocketWorkload
carlcsaposs-canonical ea7a788
fixup
carlcsaposs-canonical File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be sure, please drop a ticket to the next pulse / we need to invest here ASAP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've had an open ticket for some time, although the time estimate will likely increase after re-implementing the legacy interface (if we want to unit test the legacy interface)