Skip to content

Commit

Permalink
Refactor (#44)
Browse files Browse the repository at this point in the history
DPE-1854, DPE-1910

Ported from
canonical/mysql-router-k8s-operator#51

Changes from kubernetes PR:
- No TLS
- canonical/mysql-router-k8s-operator#93
- canonical/mysql-router-k8s-operator#97

Will re-implement legacy interface in separate PR
  • Loading branch information
carlcsaposs-canonical authored Jun 28, 2023
1 parent e1d39d4 commit a0a8704
Show file tree
Hide file tree
Showing 35 changed files with 3,857 additions and 3,883 deletions.
32 changes: 17 additions & 15 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,20 +27,21 @@ jobs:
- name: Run linters
run: tox run -e lint

unit-test:
name: Unit tests
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Install tox
# TODO: Consider replacing with custom image on self-hosted runner OR pinning version
run: python3 -m pip install tox
- name: Run tests
run: tox run -e unit
- name: Upload Coverage to Codecov
uses: codecov/codecov-action@v3
# TODO: re-enable after adding unit tests
# unit-test:
# name: Unit tests
# runs-on: ubuntu-latest
# timeout-minutes: 5
# steps:
# - name: Checkout
# uses: actions/checkout@v3
# - name: Install tox
# # TODO: Consider replacing with custom image on self-hosted runner OR pinning version
# run: python3 -m pip install tox
# - name: Run tests
# run: tox run -e unit
# - name: Upload Coverage to Codecov
# uses: codecov/codecov-action@v3

lib-check:
name: Check libraries
Expand Down Expand Up @@ -81,7 +82,8 @@ jobs:
name: ${{ matrix.tox-environments }} | ${{ matrix.ubuntu-versions.series }}
needs:
- lint
- unit-test
# TODO: re-enable after adding unit tests
# - unit-test
- build
runs-on: ubuntu-latest
timeout-minutes: 120
Expand Down
1 change: 1 addition & 0 deletions charmcraft.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,6 @@ bases:
channel: "22.04"
parts:
charm:
charm-entrypoint: src/machine_charm.py
charm-binary-python-packages:
- mysql-connector-python==8.0.32
Loading

0 comments on commit a0a8704

Please sign in to comment.