Cleanup router metadata #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlcsaposs-canonical
requested review from
delgod,
paulomach,
taurus-forever and
shayancanonical
carlcsaposs-canonical
force-pushed
the
cleanup-router-metadata
branch
from
d402747 to
a54e277
Compare
Codecov Report
@@ Coverage Diff @@
## main #208 +/- ##
==========================================
- Coverage 65.40% 63.89% -1.52%
==========================================
Files 12 12
Lines 2139 2199 +60
Branches 269 277 +8
==========================================
+ Hits 1399 1405 +6
- Misses 654 710 +56
+ Partials 86 84 -2
|
shayancanonical
approved these changes
May 17, 2023
delgod
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #207 (change base branch after #207 is merged)
Ported from canonical/mysql-k8s-operator#224