Cleanup router metadata #224
Conversation
carlcsaposs-canonical
requested review from
delgod,
paulomach,
taurus-forever and
shayancanonical
carlcsaposs-canonical
force-pushed
the
cleanup-router-metadata
branch
from
b8969e3 to
7754bd3
Compare
|
Depends on #226 |
carlcsaposs-canonical
force-pushed
the
cleanup-router-metadata
branch
from
495b3ad to
a4455c3
Compare
carlcsaposs-canonical
force-pushed
the
cleanup-router-metadata
branch
from
68a2866 to
0d11539
Compare
| self.charm._mysql.delete_user(user.username) | ||
| logger.info(f"Deleted router user {user.username}") | ||
| except MySQLDeleteUserError: | ||
| logger.error(f"Failed to delete user {user.username}") |
There was a problem hiding this comment.
maybe we should defer/retry if the deletion fails.
up to @paulomach
There was a problem hiding this comment.
I'd agree - if there's a error dropping a user it maybe the case to retry - I've also commented on the lib method to make it harder to fail.
There was a problem hiding this comment.
can this be a separate PR?
we're not doing this for other user deletion (e.g. deleting users for relation)
I'd prefer to not block canonical/mysql-router-k8s-operator#51
There was a problem hiding this comment.
Opened #228
| if len(users) > 1: | ||
| logger.error( | ||
| f"More than one router user for departing unit {event.departing_unit.name}" | ||
| ) |
There was a problem hiding this comment.
isnt it possible to have more than 1 user returned (if there are multiple applications related to the mysqlrouter application)?
There was a problem hiding this comment.
| self.charm._mysql.delete_user(user.username) | ||
| logger.info(f"Deleted router user {user.username}") | ||
| except MySQLDeleteUserError: | ||
| logger.error(f"Failed to delete user {user.username}") |
There was a problem hiding this comment.
I'd agree - if there's a error dropping a user it maybe the case to retry - I've also commented on the lib method to make it harder to fail.
Depends on #220 (change base branch after #220 is merged)
Issue
Router metadata not removed when router leaves relation
Solution
Remove metadata when router leaves relation