Skip database creation for mysqlrouter extra user role
#210
Conversation
carlcsaposs-canonical
requested review from
paulomach,
taurus-forever and
shayancanonical
Codecov Report
@@ Coverage Diff @@
## main #210 +/- ##
==========================================
- Coverage 65.40% 65.34% -0.07%
==========================================
Files 12 12
Lines 2139 2141 +2
Branches 269 270 +1
==========================================
Hits 1399 1399
- Misses 654 655 +1
- Partials 86 87 +1
|
| @@ -90,7 +90,7 @@ def wait_until_mysql_connection(self) -> None: | |||
|
|
|||
| # Increment this PATCH version before using `charmcraft publish-lib` or reset | |||
| # to 0 if you are raising the major API version | |||
| LIBPATCH = 26 | |||
| LIBPATCH = 28 | |||
There was a problem hiding this comment.
should this libpatch be 27 instead?
There was a problem hiding this comment.
preemptively bumped it for #208
There was a problem hiding this comment.
I suspect CI will fail if you try to release LIBPATCH = 27 after merging this LIBPATCH = 28 (also, AFAIK charmcraft will refuse to upload the library with gap in LIBPATCH). I could be wrong.
There was a problem hiding this comment.
yes my plan was to merge #208 first
| # TODO: | ||
| # add setup of tls, tls_ca and status |
There was a problem hiding this comment.
JFMI, is it still topical? mysql-router-k8s supports TLS since the last sprint AFAIK, mysql-router is subordinate == no TLS.
There was a problem hiding this comment.
Not sure—also this is the mysql charm, not the mysql router charm
| @@ -90,7 +90,7 @@ def wait_until_mysql_connection(self) -> None: | |||
|
|
|||
| # Increment this PATCH version before using `charmcraft publish-lib` or reset | |||
| # to 0 if you are raising the major API version | |||
| LIBPATCH = 26 | |||
| LIBPATCH = 28 | |||
There was a problem hiding this comment.
I suspect CI will fail if you try to release LIBPATCH = 27 after merging this LIBPATCH = 28 (also, AFAIK charmcraft will refuse to upload the library with gap in LIBPATCH). I could be wrong.
Ported from canonical/mysql-k8s-operator#227