Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metacontroller for kubeflow 1.4 #1
Add metacontroller for kubeflow 1.4 #1
Changes from 8 commits
af71a81
17010e7
db1856a
5e7d673
74fa19a
795323a
4887fb4
75c974e
b9694a9
838d579
aa0dcc3
92045d0
8f27442
03838fa
da5abfb
af06c84
4d1a478
74f44d2
6e38a7c
64bebb6
bfe2da4
454e7a2
4200f8c
85c3af5
24ef72b
198dd8c
29d8526
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we can probably skip the comment, seeing
if: failure()
is easy to spot for me, at leastThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one I actually like having. fwiw, I actually misread this the first time I saw it in charms. I see that comment as a header for the next 6 things, all of which happen in failures. Maybe it could be formatted differently instead?