Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metacontroller for kubeflow 1.4 #1

Merged
merged 27 commits into from
Nov 23, 2021
Merged

Add metacontroller for kubeflow 1.4 #1

merged 27 commits into from
Nov 23, 2021

Commits on Sep 22, 2021

  1. Initial commit

    * install hook has MVP functionality.  It installs correctly and monitors the stateful until it is ready.  Does not monitor/check other objs
    * includes basic test coverage
    
    Todo:
    * update-status hook
    * remove hook
    * all TODO items in code
    ca-scribner committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    af71a81 View commit details
    Browse the repository at this point in the history
  2. feat: Add remove hook

    Hook fails because kubectl cannot access environment.  Maybe juju sets up the remove hook env differently than install?
    ca-scribner committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    17010e7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    db1856a View commit details
    Browse the repository at this point in the history
  4. feat: add reconcile loop on update-status hook

    Current version will restore the state if it notices the statefulset is missing/incomplete
    ca-scribner committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    5e7d673 View commit details
    Browse the repository at this point in the history
  5. fix: tests

    ca-scribner committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    74fa19a View commit details
    Browse the repository at this point in the history
  6. fix: tests

    ca-scribner committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    795323a View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2021

  1. Configuration menu
    Copy the full SHA
    4887fb4 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2021

  1. Configuration menu
    Copy the full SHA
    75c974e View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. Configuration menu
    Copy the full SHA
    b9694a9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    838d579 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. Configuration menu
    Copy the full SHA
    aa0dcc3 View commit details
    Browse the repository at this point in the history
  2. Remove noop container

    Uses juju/juju#13442 (landed in juju 2.9.18)
    ca-scribner committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    92045d0 View commit details
    Browse the repository at this point in the history
  3. feat: Use lightkube instead of kubectl for creating objects

    WIP.  Missing unit tests and not fully tested
    ca-scribner committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    8f27442 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. Configuration menu
    Copy the full SHA
    03838fa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    da5abfb View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Configuration menu
    Copy the full SHA
    af06c84 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4d1a478 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    74f44d2 View commit details
    Browse the repository at this point in the history
  4. feat: add error message for when charm does not have trust

    Add tests for catch of trust-related error
    ca-scribner committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    6e38a7c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    64bebb6 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2021

  1. fix: mock away lightkube client in unit tests

    client fails when kube config cannot be found on system (such as in GH runner)
    ca-scribner committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    bfe2da4 View commit details
    Browse the repository at this point in the history
  2. fix: update install process to handle resource conflicts

    Install now attempts to create all resources, failing over to patching any that already exist (and logging this to debug-log).  This is not foolproof (it could overwrite existing resources)
    
    Also changed:
    * k8s resource names now slightly more unique, attempting to avoid conflicts
    * changed CI name for `test_build_and_deploy` to `test_build_and_deploy_with_trust` to make it easier to run just that test during debugging
    ca-scribner committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    454e7a2 View commit details
    Browse the repository at this point in the history
  3. fix: formatting

    ca-scribner committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    4200f8c View commit details
    Browse the repository at this point in the history
  4. fix: disable _no_trust integration test

    Seems to be colliding with the regular deploy test, maybe because the second test starts before the first is fully torn down?  Not sure, but both work in isolation locally.
    ca-scribner committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    85c3af5 View commit details
    Browse the repository at this point in the history
  5. Refactor to address review comments

    * refactor _create and _render to minimize duplicated code
    * misc minor changes
    ca-scribner committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    24ef72b View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. Refactor to address review comments

    Includes:
    * Removing properties for simplicity
    * Using tenacity.retry instead of while loop for checking resources
    * Using CheckFailed exception for raising errors in helpers
    * Scheduled weekly integration CI
    ca-scribner committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    198dd8c View commit details
    Browse the repository at this point in the history
  2. fix: test_check_deployed_resources

    Restore assignment of mock object that was removed by mistake
    ca-scribner committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    29d8526 View commit details
    Browse the repository at this point in the history