Add metacontroller for kubeflow 1.4 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* install hook has MVP functionality. It installs correctly and monitors the stateful until it is ready. Does not monitor/check other objs * includes basic test coverage Todo: * update-status hook * remove hook * all TODO items in code
Hook fails because kubectl cannot access environment. Maybe juju sets up the remove hook env differently than install?
Current version will restore the state if it notices the statefulset is missing/incomplete
|
This charm is missing RBAC needed for the status checking. Currently it breaks when RBAC is enabled |
knkski
reviewed
Nov 13, 2021
jnsgruk
reviewed
Nov 15, 2021
Uses juju/juju#13442 (landed in juju 2.9.18)
WIP. Missing unit tests and not fully tested
Add tests for catch of trust-related error
This was referenced Nov 18, 2021
|
DnPlas
reviewed
Nov 18, 2021
You can stop the behaviour where @patch("lightkube.core.client.GenericSyncClient", Mock) |
client fails when kube config cannot be found on system (such as in GH runner)
Install now attempts to create all resources, failing over to patching any that already exist (and logging this to debug-log). This is not foolproof (it could overwrite existing resources) Also changed: * k8s resource names now slightly more unique, attempting to avoid conflicts * changed CI name for `test_build_and_deploy` to `test_build_and_deploy_with_trust` to make it easier to run just that test during debugging
Seems to be colliding with the regular deploy test, maybe because the second test starts before the first is fully torn down? Not sure, but both work in isolation locally.
* refactor _create and _render to minimize duplicated code * misc minor changes
Includes: * Removing properties for simplicity * Using tenacity.retry instead of while loop for checking resources * Using CheckFailed exception for raising errors in helpers * Scheduled weekly integration CI
Restore assignment of mock object that was removed by mistake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an MVP of the charm. A fully implemented charm should have better status handling, teardown, etc.PR is now fully fleshed out charm for the Metacontroller. If things are missing, I missed them!