CI run for contributor PR #25160 #26018
Draft
+88
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
github-actions
bot
force-pushed
the
contributor-Ilie-Lesan-browser-crashed-while-dragging-tab-group-out-of-current-window
branch
from
890a61a
to
4c683e1
Compare
…window when split view is enabled and fix interactive ui test build
… of the window when split view is enabled and fix interactive ui test build" This reverts commit 40ed7c1.
upstream also only runs this test on Windows. Also use //brave/browser/ui/views/tabs::browser_tests target for tab browser test cases.
github-actions
bot
force-pushed
the
contributor-Ilie-Lesan-browser-crashed-while-dragging-tab-group-out-of-current-window
branch
from
4c683e1
to
4593f38
Compare
| @@ -187,9 +187,9 @@ void TabDragController::DetachAndAttachToNewContext( | |||
| std::vector<tabs::TabHandle> tabs; | |||
| auto* tab_strip_model = browser->tab_strip_model(); | |||
| DCHECK_EQ(tab_strip_model, attached_context_->GetTabStripModel()); | |||
| for (const auto& tab_drag_data : drag_data_) { | |||
| for (size_t i = first_tab_index(); i < drag_data_.size(); ++i) { | |||
There was a problem hiding this comment.
This here should be something like:
auto drag_data = base::span(drag_data_).subspan(first_tab_index());
for (const auto& tab_drag_data : drag_data) {
...This way we don't access the subscript directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is created to run CI on the changes proposed in PR #25160 by @Ilie-Lesan.
This PR should not be merged.