Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI run for contributor PR #25160 #26018

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

CI run for contributor PR #25160 #26018

wants to merge 5 commits into from
+88 −3

Commits on Oct 16, 2024

  1. Use the proper index when dragging a tab group

    @Ilie-Lesan @brave-browser-releases
    Ilie-Lesan authored and brave-browser-releases committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    1826571 View commit details
    Browse the repository at this point in the history

  2. Add a test for the scenario when a user drags a tab group out of the … 

    …window when split view is enabled and fix interactive ui test build
    @Ilie-Lesan @brave-browser-releases
    Ilie-Lesan authored and brave-browser-releases committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    6c7e9c4 View commit details
    Browse the repository at this point in the history

  3. Revert "Add a test for the scenario when a user drags a tab group out… 

    … of the window when split view is enabled and fix interactive ui test build"

This reverts commit 40ed7c1.
    @Ilie-Lesan @brave-browser-releases
    Ilie-Lesan authored and brave-browser-releases committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    c4787f2 View commit details
    Browse the repository at this point in the history

  4. Add a browser test for tab group drag issue

    @Ilie-Lesan @brave-browser-releases
    Ilie-Lesan authored and brave-browser-releases committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    5cfe952 View commit details
    Browse the repository at this point in the history

  5. Disabled group detach test on macOS and Linux 

    upstream also only runs this test on Windows.
Also use //brave/browser/ui/views/tabs::browser_tests target for
tab browser test cases.
    @simonhong @brave-browser-releases
    simonhong authored and brave-browser-releases committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    4593f38 View commit details
    Browse the repository at this point in the history