Disabled group detach test on macOS and Linux

upstream also only runs this test on Windows. Also use //brave/browser/ui/views/tabs::browser_tests target for tab browser test cases.
brave · Oct 16, 2024 · 4593f38 · 4593f38
1 parent 5cfe952
commit 4593f38
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 3 deletions.
diff --git a/browser/ui/views/tabs/BUILD.gn b/browser/ui/views/tabs/BUILD.gn
@@ -9,7 +9,10 @@ source_set("browser_tests") {
   testonly = true
   defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ]
 
-  sources = [ "//brave/browser/ui/views/tabs/brave_tab_hover_browsertest.cc" ]
+  sources = [
+    "//brave/browser/ui/views/tabs/brave_tab_hover_browsertest.cc",
+    "//brave/browser/ui/views/tabs/tab_drag_controller_browsertest.cc",
+  ]
 
   deps = [
     "//base",

diff --git a/browser/ui/views/tabs/tab_drag_controller_browsertest.cc b/browser/ui/views/tabs/tab_drag_controller_browsertest.cc
@@ -39,8 +39,19 @@ class TabDragControllerTest : public InProcessBrowserTest {
   base::test::ScopedFeatureList scoped_feature_list_;
 };
 
+#if BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX)
+// It's flaky. Upstream also runs group header detach test only on Windows.
+// See
+// DetachToBrowserTabDragControllerTest.MAYBE_DragGroupHeaderToSeparateWindow
+#define MAYBE_DragGroupHeaderToSeparateWindow \
+  DISABLED_DragGroupHeaderToSeparateWindow
+#else
+#define MAYBE_DragGroupHeaderToSeparateWindow DragGroupHeaderToSeparateWindow
+#endif
+
 // Browser test for https://github.com/brave/brave-browser/issues/39486
-IN_PROC_BROWSER_TEST_F(TabDragControllerTest, DragGroupHeaderToSeparateWindow) {
+IN_PROC_BROWSER_TEST_F(TabDragControllerTest,
+                       MAYBE_DragGroupHeaderToSeparateWindow) {
   ASSERT_TRUE(browser()->tab_strip_model()->SupportsTabGroups());
   tab_groups::TabGroupId group = AddTabToNewGroup(browser(), 0);
   AppendTab(browser());

diff --git a/test/BUILD.gn b/test/BUILD.gn
@@ -1119,7 +1119,6 @@ test("brave_browser_tests") {
       "//brave/browser/ui/views/omnibox/omnibox_autocomplete_browsertest.cc",
       "//brave/browser/ui/views/profiles/brave_profile_menu_view_browsertest.cc",
       "//brave/browser/ui/views/tabs/brave_tab_context_menu_contents_browsertest.cc",
-      "//brave/browser/ui/views/tabs/tab_drag_controller_browsertest.cc",
       "//brave/browser/ui/views/tabs/vertical_tab_strip_browsertest.cc",
       "//brave/browser/ui/views/toolbar/brave_app_menu_browsertest.cc",
       "//brave/browser/ui/views/toolbar/brave_toolbar_view_browsertest.cc",