Drop LimitCollectionCreationDeletion from the database

[addisonbeck]

🎟️ Tracking

🧵 Jira Ticket: PM-10863

📚 Stacked PRs

1. server: Split LimitCollectionCreationDeletion into two database columns #4709
2. server: Split Organization.LimitCollectionCreationDeletion into two separate business rules #4730
3. clients: Split Organization.LimitCollectionCreationDeletion into two separate business rules clients#11223
4. server: Turn on LimitCollectionCreationDeletionSplit for self host #4808
5. server: Remove LimitCollectionCreationDeletionSplit feature flag #4809
6. clients: Remove LimitCollectionCreationDeletionSplit feature flag clients#11258
7. server: Drop LimitCollectionCreationDeletion from the database #4810
   ⬆️ YOU ARE HERE

📔 Objective

🤳 The Bigger Picture

There is an option in the Admin Console that removes collection creation and
deletion controls from all organization members that are not in the Owner and
Admin roles. This PR stack splits this conjoined option into two separate
controls: one to block create operations and one to block delete
operations. This is a part of an effort to make these settings better align
with what customers expect it to do.

👉 This Pull Request 👍

This is the final pull request in this stack. This commit includes:

1. Removal of the LimitCollectionCreationDeletion database column from all
   database providers.
2. Removal of the use of LimitCollectionCreationDeletion from all MSSSQL
   views, stored procedures, etc.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 91da390c-8bfa-493e-af32-2d664af1b2a3

No New Or Fixed Issues Found

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.81%. Comparing base (c735cd4) to head (8437f5f).

Additional details and impacted files

@@                              Coverage Diff                              @@
##           ac/addison/pm-10863/remove-feature-toggle    #4810      +/-   ##
=============================================================================
- Coverage                                      41.82%   41.81%   -0.01%     
=============================================================================
  Files                                           1320     1320              
  Lines                                          62706    62700       -6     
  Branches                                        5777     5776       -1     
=============================================================================
- Hits                                           26225    26219       -6     
  Misses                                         35270    35270              
  Partials                                        1211     1211              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.