Remove LimitCollectionCreationDeletionSplit feature flag

[addisonbeck]

🎟️ Tracking

🧵 Jira Ticket: PM-10863

📚 Stacked PRs

1. server: Split LimitCollectionCreationDeletion into two database columns server#4709
2. server: Split Organization.LimitCollectionCreationDeletion into two separate business rules server#4730
3. clients: Split Organization.LimitCollectionCreationDeletion into two separate business rules #11223
4. server: Turn on LimitCollectionCreationDeletionSplit for self host server#4808
5. server: Remove LimitCollectionCreationDeletionSplit feature flag server#4809
6. clients: Remove LimitCollectionCreationDeletionSplit feature flag #11258
   ⬆️ YOU ARE HERE
7. server: Drop LimitCollectionCreationDeletion from the database server#4810

📔 Objective

🤳 The Bigger Picture

There is an option in the Admin Console that removes collection creation and
deletion controls from all organization members that are not in the Owner and
Admin roles. This PR stack splits this conjoined option into two separate
controls: one to block create operations and one to block delete
operations. This is a part of an effort to make these settings better align
with what customers expect it to do.

👉 This Pull Request 👍

This PR is a part of the cleanup phase for this stack. All functional changes
were implemented and released over the previous PRs and is availible for use
in production. This pull request removes the
LimitCollectionCreationDeletionSplit feature flag, all of its references,
and all associated model code from the admin console.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 94414b52-00e0-439b-a5b8-6d3bcf341fcd

No New Or Fixed Issues Found

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 33.22%. Comparing base (4e932e3) to head (d237323).

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...onsole/organizations/settings/account.component.ts	0.00%	3 Missing ⚠️

Additional details and impacted files

@@                                      Coverage Diff                                      @@
##           ac/addison/pm-10863/limit-collection-creation-deletion-split   #11258   +/-   ##
=============================================================================================
  Coverage                                                         33.22%   33.22%           
=============================================================================================
  Files                                                              2730     2730           
  Lines                                                             85279    85260   -19     
  Branches                                                          16225    16221    -4     
=============================================================================================
- Hits                                                              28332    28328    -4     
+ Misses                                                            54691    54676   -15     
  Partials                                                           2256     2256           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.