Split Organization.LimitCollectionCreationDeletion into two separate business rules
#11223
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11223 +/- ##
=======================================
Coverage 33.29% 33.29%
=======================================
Files 2731 2731
Lines 85549 85569 +20
Branches 16318 16322 +4
=======================================
+ Hits 28480 28487 +7
- Misses 54811 54824 +13
Partials 2258 2258 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
addisonbeck
force-pushed
the
ac/addison/pm-10863/limit-collection-creation-deletion-split
branch
3 times, most recently
from
1a62e82
to
8b06739
Compare
addisonbeck
changed the title
LimitCollectionCreationDeletion in twoOrganization.LimitCollectionCreationDeletion into two separate business rules
addisonbeck
force-pushed
the
ac/addison/pm-10863/limit-collection-creation-deletion-split
branch
from
8b06739
to
4e932e3
Compare
| @@ -61,6 +66,15 @@ export class AccountComponent implements OnInit, OnDestroy { | |||
| }), | |||
| }); | |||
|
|
|||
| protected collectionManagementFormGroup_VNext = this.formBuilder.group({ | |||
There was a problem hiding this comment.
I can see the vNext formgroup is used in the TS code, but it doesn't appear to be referenced in the template.
| this.configService | ||
| .getFeatureFlag$(FeatureFlag.LimitCollectionCreationDeletionSplit) | ||
| .pipe(takeUntil(this.destroy$)) | ||
| .subscribe((x) => (this.limitCollectionCreationDeletionSplitFeatureFlagIsEnabled = x)); |
There was a problem hiding this comment.
I recommend against subscribing, then you can just do a 1-liner: this.limitCollectionCreationDeletionSplitFeatureFlagIsEnabled = this.configService.getFeatureFlag$(FeatureFlag.LimitCollectionCreationDeletionSplit);.
Although I admit using await firstValueFrom is a bit awkward, that may come down to personal preference.
addisonbeck
force-pushed
the
ac/addison/pm-10863/limit-collection-creation-deletion-split
branch
2 times, most recently
from
222faf6
to
e78c97b
Compare
addisonbeck
force-pushed
the
ac/addison/pm-10863/limit-collection-creation-deletion-split
branch
from
e78c97b
to
c712b07
Compare
🎟️ Tracking
🧵 Jira Ticket: PM-10863
📚 Stacked PRs
server: SplitLimitCollectionCreationDeletioninto two database columns server#4709server: SplitOrganization.LimitCollectionCreationDeletioninto two separate business rules server#4730clients: SplitOrganization.LimitCollectionCreationDeletioninto two separate business rules #11223⬆️ YOU ARE HERE
server: Turn onLimitCollectionCreationDeletionSplitfor self host server#4808server: RemoveLimitCollectionCreationDeletionSplitfeature flag server#4809clients: RemoveLimitCollectionCreationDeletionSplitfeature flag #11258server: DropLimitCollectionCreationDeletionfrom the database server#4810📔 Objective
🤳 The Bigger Picture
There is an option in the Admin Console that removes collection creation and
deletion controls from all organization members that are not in the Owner and
Admin roles. This PR stack splits this conjoined option into two separate
controls: one to block
createoperations and one to blockdeleteoperations. This is a part of an effort to make these settings better align
with what customers expect it to do.
👉 This Pull Request 👍
In the previous PR we implemented the new functionality requested from this
effort in
server. On this PR we apply those new rules toclients. Thisinvolves adding the feature toggle to
clientsand implementing two newboolean settings in the admin console behind that feature toggle.
This PR, its predecessor in
server, and the next PR in the stack encompassall of the functional changes to the system implemented by this PR stack. The
first pull request and the last two in the stack are for maintenance to
support evolutionary database design and feature toggling.
🧮 Side Effects
LimitCollectionCreationDeletionandAllowAdminsAccessToAllCollectionsfrom the license file used for selfhosted: the new controls are not disabled for self hosted organizations.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes