Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

Library: power, UART, I2C, RS232 components... #38

Merged
merged 27 commits into from
Sep 16, 2024
Merged

Library: power, UART, I2C, RS232 components... #38

merged 27 commits into from
Sep 16, 2024

Conversation

ruben-iteng
Copy link
Collaborator

@ruben-iteng ruben-iteng commented Sep 5, 2024 •
edited
Loading

Library: power, UART, I2C, RS232 components...

Description

New and fixed library modules.
Also extended ElectricPower and some other fixes and additions.

new:

  • B0505 isolated DCDC converter
  • CH344x quad usb uart bridge
  • DE-9 RS232 connector
  • ISO1540 isolated RS485 tranceiver
  • PowerMux base module
  • TPS2116 Power mux
  • RS232 tranceiver
  • CH342F dual usb uart bridge
  • AP2552W6
  • INA288
  • ElectricalRCFilter
  • USB2514B ref design
  • ResistorVoltageDivider

additions:

  • ElectricPower fused function
  • ElectricPower sink trait

Checklist

Please read and execute the following:

  • My code follows the coding guidelines of this project
  • My PR title is following the contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I ran Black to format my code

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct:

@ruben-iteng ruben-iteng self-assigned this Sep 5, 2024
@ruben-iteng ruben-iteng added the enhancement New feature or request label Sep 5, 2024
@ruben-iteng ruben-iteng changed the title Library: Add: power, uart, I2c, RS232 components Library: Add: power, UART, I2C, RS232 components Sep 5, 2024
iopapamanoglou
iopapamanoglou suggested changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@iopapamanoglou iopapamanoglou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice and clean!
Use this reference for decoding the comments: https://www.notion.so/fab-ll-cc605de24dda412ba7e6bb8de5b9f308

I see working with decoupling caps is annoying, lets figure out a better way.
#40

src/faebryk/library/B0505S_1WR3.py Outdated Show resolved Hide resolved
src/faebryk/library/B0505S_1WR3.py Outdated Show resolved Hide resolved
src/faebryk/library/CH342.py Outdated Show resolved Hide resolved
src/faebryk/library/CH342.py Outdated Show resolved Hide resolved
src/faebryk/library/CH342F.py Outdated Show resolved Hide resolved
src/faebryk/library/SP3243E.py Outdated Show resolved Hide resolved
src/faebryk/library/SP3243E.py Outdated Show resolved Hide resolved
src/faebryk/library/SP3243E.py Outdated Show resolved Hide resolved
src/faebryk/library/SP3243E.py Outdated Show resolved Hide resolved
src/faebryk/library/TPS2116.py Outdated Show resolved Hide resolved
@ruben-iteng ruben-iteng force-pushed the feature/add_uart_rs232_power_components branch from ec70f51 to f511541 Compare September 12, 2024 09:47
@ruben-iteng ruben-iteng changed the title Library: Add: power, UART, I2C, RS232 components Library: power, UART, I2C, RS232 components... Sep 12, 2024
@ruben-iteng ruben-iteng marked this pull request as ready for review September 12, 2024 18:19
iopapamanoglou
iopapamanoglou reviewed Sep 13, 2024
View reviewed changes
Copy link
Contributor

@iopapamanoglou iopapamanoglou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks already way better, nearly there!

src/faebryk/library/CH342.py Outdated Show resolved Hide resolved
src/faebryk/library/CH342.py Outdated Show resolved Hide resolved
src/faebryk/library/CH342F.py Outdated Show resolved Hide resolved
src/faebryk/library/CH342F.py Outdated Show resolved Hide resolved
src/faebryk/library/CH342F.py Outdated Show resolved Hide resolved
src/faebryk/library/ISO1540.py Outdated Show resolved Hide resolved
src/faebryk/library/SP3243E.py Outdated Show resolved Hide resolved
src/faebryk/library/TPS2116.py Outdated Show resolved Hide resolved
src/faebryk/library/TPS2116.py Outdated Show resolved Hide resolved
src/faebryk/library/USB2514B_ReferenceDesign.py Show resolved Hide resolved
ruben-iteng and others added 21 commits September 15, 2024 14:43
@ruben-iteng
Add: power, uart, I2c, RS232 components
13f0fe0 
- B0505 isolated DCDC converter
- CH344x quad usb uart bridge
- DE-9 RS232 connector
- ISO1540 isolated RS485 tranceiver
- PowerMux base module
- TPS2116 Power mux
- RS232 tranceiver
@ruben-iteng
Add: missing module interfaces
f8a33de
@ruben-iteng
Add: CH342F
5766e3f
@ruben-iteng
Various fixes and additions
f1a51dd
@ruben-iteng
Fix: comply with most of fabll code guidelines
b1246f4
@ruben-iteng
Add: INA288
b6528b3
@ruben-iteng
Fix: references
2b4c5ae 
Add:
- AP2552W6
- ElectricalRCFilter
- USB2514B ref design
- ResistorVoltageDivider
@ruben-iteng
Add: common designater prefixes
38fb306
@ruben-iteng
Fix: libadd pin duplication
5a89b32
@ruben-iteng
Fix: led power
6dc8d5a
@ruben-iteng
Fix: recursion
a7bc950
@ruben-iteng
Fix: CH344Q ref des and ISO1540
07ed6b8
@ruben-iteng
Add: fused to ElectricPower
4c87071
@ruben-iteng
Add: ElectricPower fused test
0db176c
@ruben-iteng
Add: sink trait
7d874d5
@ruben-iteng
Fix: connections
322321f
@ruben-iteng
Fix: Create file/path if not existing
102cba2
@iopapamanoglou @ruben-iteng
proper path usage in export_parameters
43b662d
@iopapamanoglou @ruben-iteng
Add electriclogic helper
a809c7e
@iopapamanoglou @ruben-iteng
fix once; improve fused()
f4e4aec
@iopapamanoglou @ruben-iteng
minor fixes
1221d90
@ruben-iteng ruben-iteng force-pushed the feature/add_uart_rs232_power_components branch from 99764d8 to 5e443b0 Compare September 15, 2024 16:30
@ruben-iteng
Copy link
Collaborator Author

ruben-iteng commented Sep 15, 2024 •
edited
Loading

@iopapamanoglou assert_once is broken (as you said). It does not work when you use more than 1 of the same module that uses a function with assert_once. e.g. in the tests...
commented it out for now.

once is also broken 🤔 (see test results ci)

@iopapamanoglou iopapamanoglou merged commit dd7c400 into main Sep 16, 2024
2 checks passed
@iopapamanoglou iopapamanoglou deleted the feature/add_uart_rs232_power_components branch September 16, 2024 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iopapamanoglou iopapamanoglou iopapamanoglou approved these changes

Assignees

@ruben-iteng ruben-iteng

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruben-iteng @iopapamanoglou