Reliability: Flow types for tests (part 3)

flow-typed/node/assert.js

@@ -0,0 +1,55 @@
+// Missing flow types for node:assert
+declare module "assert" {
+  declare class AssertionError extends Error {}
+  declare type AssertStrict = {
+    (value: any, message?: string): void;
+    ok(value: any, message?: string): void;
+    fail(message?: string | Error): void;
+    // deprecated since v10.15
+    // fail(actual: any, expected: any, message: string, operator: string): void;
+    equal(actual: any, expected: any, message?: string): void;
+    notEqual(actual: any, expected: any, message?: string): void;
+    deepEqual(actual: any, expected: any, message?: string): void;
+    notDeepEqual(actual: any, expected: any, message?: string): void;
+    throws(
+      block: Function,
+      error?: Function | RegExp | (err: any) => boolean,
+      message?: string
+    ): void;
+    doesNotThrow(block: Function, message?: string): void;
+    ifError(value: any): void;
+    AssertionError: typeof AssertionError;
+    strict: AssertStrict;
+    ...
+  }
+  declare module.exports: {
+    (value: any, message?: string): void,
+    ok(value: any, message?: string): void,
+    fail(message?: string | Error): void,
+    // deprecated since v10.15
+    // fail(actual: any, expected: any, message: string, operator: string): void,
+    equal(actual: any, expected: any, message?: string): void,
+    notEqual(actual: any, expected: any, message?: string): void,
+    deepEqual(actual: any, expected: any, message?: string): void,
+    notDeepEqual(actual: any, expected: any, message?: string): void,
+    strictEqual(actual: any, expected: any, message?: string): void,
+    notStrictEqual(actual: any, expected: any, message?: string): void,
+    deepStrictEqual(actual: any, expected: any, message?: string): void,
+    notDeepStrictEqual(actual: any, expected: any, message?: string): void,
+    throws(
+      block: Function,
+      error?: Function | RegExp | (err: any) => boolean,
+      message?: string
+    ): void,
+    doesNotThrow(block: Function, message?: string): void,
+    rejects(
+      block: Function,
+      error?: Function | RegExp | (err: any) => boolean,
+      message?: string
+    ): void;
+    ifError(value: any): void,
+    AssertionError: typeof AssertionError,
+    strict: AssertStrict;
+    ...
+  }
+}

packages/core/integration-tests/test/bundler.js

@@ -887,10 +887,10 @@ describe('bundler', function () {
     ]);
 
     let assetBar = findAsset(b, 'bar.js');
-    if (!assetBar) return assert(false);
+    if (!assetBar) return assert.fail();
 
     let assetC = findAsset(b, 'c.js');
-    if (!assetC) return assert(false);
+    if (!assetC) return assert.fail();
 
     assert(
       b
@@ -957,7 +957,7 @@ describe('bundler', function () {
       .find(
         (bundle) => !bundle.getMainEntry() && bundle.name.includes('runtime'),
       );
-    if (!aManifestBundle) return assert(false);
+    if (!aManifestBundle) return assert.fail();
 
     let bBundles = b
       .getBundles()
@@ -970,7 +970,7 @@ describe('bundler', function () {
         stop();
       }
     });
-    if (!aBundleManifestAsset) return assert(false);
+    if (!aBundleManifestAsset) return assert.fail();
 
     let aBundleManifestAssetCode = await aBundleManifestAsset.getCode();
 
@@ -1333,7 +1333,7 @@ describe('bundler', function () {
 
     // Asset should not be inlined
     const index = b.getBundles().find((b) => b.name.startsWith('index'));
-    if (!index) return assert(false);
+    if (!index) return assert.fail();
 
     const contents = overlayFS.readFileSync(index.filePath, 'utf8');
     assert(

packages/core/integration-tests/test/contentHashing.js

@@ -1,3 +1,4 @@
+// @flow
 import assert from 'assert';
 import path from 'path';
 import {
@@ -99,11 +100,19 @@ describe('content hashing', function () {
     async () => {
       let a = await _bundle(
         path.join(__dirname, 'integration/hash-distDir/a/index.html'),
-        {sourceMaps: true},
+        {
+          defaultTargetOptions: {
+            sourceMaps: true,
+          },
+        },
       );
       let b = await _bundle(
         path.join(__dirname, 'integration/hash-distDir/b/index.html'),
-        {sourceMaps: true},
+        {
+          defaultTargetOptions: {
+            sourceMaps: true,
+          },
+        },
       );
 
       let aBundles = a.getBundles();
@@ -113,7 +122,11 @@ describe('content hashing', function () {
       assert.equal(bBundles.length, 2);
 
       let aJS = aBundles.find((bundle) => bundle.type === 'js');
+      if (!aJS) return assert.fail();
+
       let bJS = bBundles.find((bundle) => bundle.type === 'js');
+      if (!bJS) return assert.fail();
+
       assert(/index\.[a-f0-9]*\.js/.test(path.basename(aJS.filePath)));
       assert.equal(aJS.name, bJS.name);
     },

packages/core/integration-tests/test/globals.js

@@ -1,3 +1,4 @@
+// @flow
 import assert from 'assert';
 import path from 'path';
 
@@ -58,7 +59,6 @@ describe('globals', function () {
     it('when scope hoisting is disabled', async function () {
       let bundleGraph = await bundle(path.join(dir, 'index.js'), {
         defaultTargetOptions: {
-          context: 'browser',
           shouldScopeHoist: false,
         },
         inputFS: overlayFS,
@@ -84,7 +84,6 @@ describe('globals', function () {
     it.v2('when scope hoisting is enabled', async function () {
       let bundleGraph = await bundle(path.join(dir, 'index.js'), {
         defaultTargetOptions: {
-          context: 'browser',
           shouldScopeHoist: true,
         },
         inputFS: overlayFS,