Reliability: Flow types for tests (part 3) #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alshdavid
changed the title
alshdavid
force-pushed
the
alsh/add-flow-to-tests-2
branch
from
7bdb3d9 to
abc343c
Compare
alshdavid
force-pushed
the
alsh/add-flow-to-tests-3
branch
from
09f2254 to
f65a1b7
Compare
alshdavid
commented
Dec 12, 2024
There was a problem hiding this comment.
defaultTargetOptions.context is not on InitialOptions and does not appear to be used within core
alshdavid
commented
Dec 12, 2024
| @@ -1,4 +1,5 @@ | |||
| import assert from 'assert'; | |||
| // @flow | |||
| import assert from 'assert/strict'; | |||
There was a problem hiding this comment.
Using local node:assert definition to add in assert.rejects
alshdavid
changed the title
alshdavid
commented
Dec 12, 2024
flow-typed/node/assert.js
Outdated
There was a problem hiding this comment.
flow types missing for assert.rejects and assert.fail, using override to pass type check
alshdavid
commented
Dec 12, 2024
| @@ -2317,7 +2333,7 @@ describe('html', function () { | |||
| }); | |||
|
|
|||
| // could run in either order. | |||
| assert(output.sort(), ['a', 'b', 'c']); | |||
There was a problem hiding this comment.
assert(['a', 'b', 'c', 'c'], ['a', 'b', 'c'])Was erroneously passing. I have updated the assertion to include the missing asset. From the assertBundles above, my change looks correct but I'm not 100% sure. Please confirm that it's the expected output
yamadapc
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from here