Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reliability: Flow types for tests (part 3) #278

Merged
merged 19 commits into from
Dec 12, 2024
Prev Previous commit
Next Next commit
globals
alshdavid committed Dec 12, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 20655605ed108592c660c65b8339d7484c988a19
3 changes: 1 addition & 2 deletions packages/core/integration-tests/test/globals.js
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defaultTargetOptions.context is not on InitialOptions and does not appear to be used within core

Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// @flow
import assert from 'assert';
import path from 'path';

@@ -58,7 +59,6 @@ describe('globals', function () {
it('when scope hoisting is disabled', async function () {
let bundleGraph = await bundle(path.join(dir, 'index.js'), {
defaultTargetOptions: {
context: 'browser',
shouldScopeHoist: false,
},
inputFS: overlayFS,
@@ -84,7 +84,6 @@ describe('globals', function () {
it.v2('when scope hoisting is enabled', async function () {
let bundleGraph = await bundle(path.join(dir, 'index.js'), {
defaultTargetOptions: {
context: 'browser',
shouldScopeHoist: true,
},
inputFS: overlayFS,