Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed memory leaks in fem_poisson #196

Merged
merged 4 commits into from
Sep 10, 2023
Merged

Fixed memory leaks in fem_poisson #196

merged 4 commits into from
Sep 10, 2023

Commits on Sep 9, 2023

  1. Fixed memory leaks in superlup_ops code. The problems here were many: 

    the A, B, L, U matrix pointers were not freed. Further, by mistake the
incorrect free method was called on brhs: this is a
gkyl_array. Instead of calling gkyl_array_release the method gkyl_free
was being called. This meant that the array was not actually freed at
all. This likely does not fix all the problems with fem_poisson but
step at a time!
    @ammarhakim
    ammarhakim committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    27e273f View commit details
    Browse the repository at this point in the history

  2. Removing the commented out line left behind from debugging

    @ammarhakim
    ammarhakim committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    08539c0 View commit details
    Browse the repository at this point in the history

  3. Fixed the incorrectly allocated kSq_ho array. It should have num_basis 

    elements and not 1 element.
    @ammarhakim
    ammarhakim committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    a71c1dd View commit details
    Browse the repository at this point in the history

  4. Fixing similar errors in fem_poisson_perp. This exercise has made me … 

    …realize a potential reason for the periodic case to not work in fem_poisson_perp: the size of rhs_cellavg is wrong because it is likely using local instead of local_ext. I will fix this in another branch, where I'll in fact move the calculation of rhs_cellavg out of fem_poisson.
    @manauref
    manauref committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    71fcd4a View commit details
    Browse the repository at this point in the history