Fixed memory leaks in fem_poisson #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the A, B, L, U matrix pointers were not freed. Further, by mistake the incorrect free method was called on brhs: this is a gkyl_array. Instead of calling gkyl_array_release the method gkyl_free was being called. This meant that the array was not actually freed at all. This likely does not fix all the problems with fem_poisson but step at a time!
elements and not 1 element.
|
Closing PR as one more issue needs resolution. |
|
Seems that this PR is indeed ready to be merged. So I am reopening it. The issue Mana found is a problem with the dg bin ops not allowing different ranges for the two input arrays. This is a more elaborate problem and will need careful look to fix throughout the code. Can't do it in this branch |
|
Reopening PR. |
…realize a potential reason for the periodic case to not work in fem_poisson_perp: the size of rhs_cellavg is wrong because it is likely using local instead of local_ext. I will fix this in another branch, where I'll in fact move the calculation of rhs_cellavg out of fem_poisson.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some memory leaks and misallocated arrays in fem_poisson and superlu_ops. These are fixed. The fem_poisson unit tests are now fully valgrind clean! All is good with the world again.