Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark some options in the share modal be "suggested" #904

Open
2 tasks done
andrewtavis opened this issue Jun 15, 2024 · 8 comments
Open
2 tasks done

Mark some options in the share modal be "suggested" #904

andrewtavis opened this issue Jun 15, 2024 · 8 comments
Assignees
Labels
design Relates to UX/UI designs hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Jun 15, 2024

Terms

Description

This issue would look into design changes to the frontend/components/modal/ModalSharePage.vue such that some of the options would be suggested and others wouldn't be. This would be a step of curation for the platform to communicate to users that some options are more safe than others to use. We'd also need a way to convey the reason why some options are suggested to the user, which is open to suggestions :)

Contribution

Happy to work on this with people and discuss how best to have this function!

@andrewtavis andrewtavis added help wanted Extra attention is needed design Relates to UX/UI designs labels Jun 15, 2024
@andrewtavis
Copy link
Member Author

@GrandSuccess87: let me know what you think on this one!

@andrewtavis andrewtavis added the hacktoberfest Included as a part of Hacktoberfest label Oct 1, 2024
@Mahendradoak
Copy link
Contributor

github
should it be similar to this?

@andrewtavis
Copy link
Member Author

I'd say that we can maybe simplify it and add say an apostrophe to the icon and have a line under it that says that those are the ones that we'd suggest people use. This suggestion visual element should be included in the component for a ModalSharePage element such that we can toggle it.

Would you like to work on this, @Mahendradoak? :)

@Mahendradoak
Copy link
Contributor

i would love to try

@andrewtavis
Copy link
Member Author

Sure thing :) Please let us know if you need any assistance!

CC @UnknownSean8 here as well as he's been working on the share component and made the component we'll be editing 😊

@Mahendradoak
Copy link
Contributor

yes, will do

@Mahendradoak Mahendradoak mentioned this issue Jan 13, 2025
1 task
@Mahendradoak
Copy link
Contributor

The key updates i have tried to include:

New showSuggestions prop: This allows the component to conditionally display a suggestion note and icons next to specific social media buttons.

suggestedOptions array: A new array holds the names of suggested social media components (e.g., Telegram, Mastodon, Email, Signal), and these buttons are marked with a small suggestion icon when relevant.

Updated button components: Conditional rendering of the suggestion icon for the listed platforms.

@andrewtavis
Copy link
Member Author

We're not going to need the prop to show suggestions as they will be shown always, @Mahendradoak :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Relates to UX/UI designs hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

2 participants