Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Facebook Messenger to Modal Share Page Component #698

Closed
2 tasks done
GrandSuccess87 opened this issue Feb 10, 2024 · 8 comments
Closed
2 tasks done

Add Facebook Messenger to Modal Share Page Component #698

GrandSuccess87 opened this issue Feb 10, 2024 · 8 comments
Assignees
Labels
feature New feature or request

Comments

@GrandSuccess87
Copy link
Contributor

Terms

Description

This issue will focus on adding support to share activist pages (event/organization/group) on Facebook Messenger via the modal share page component.

This component lives in frontend/components/modal.

Icons would ideally come from one icon source on Icones such as CoreUI Brands.

  • You may also find the icons you need on Bootstrap.

Contribution

Happy to pair up with someone on this or tackle it myself :))

@GrandSuccess87 GrandSuccess87 added the feature New feature or request label Feb 10, 2024
@GrandSuccess87
Copy link
Contributor Author

Note: Modal Share Page Component #581 is in progress

@UnknownSean8
Copy link
Contributor

Hi, I can work on this issue together with the other social media icons for the modal share page since I've worked on the Signal icon. Thanks!

@andrewtavis
Copy link
Member

Thanks @UnknownSean8! Let us know if we can support somehow :) :)

@UnknownSean8
Copy link
Contributor

Hi, sorry for the delay, I will finish this by this weekend.

@andrewtavis
Copy link
Member

Nice, @UnknownSean8! Looking forward to the PR :)

@UnknownSean8
Copy link
Contributor

Mhm, question: i18n checks doesn't support formatted strings?

For example: toast(t(components.btn_share_icon.opening_${props.text.toLowerCase()}));

@andrewtavis
Copy link
Member

No they don't. It is a drawback of the system, but it's the only way to do it without getting into some really weird code parsing.

@andrewtavis
Copy link
Member

Closed by #1070 🚀 Thanks for the dedication to getting the share modal up to a great level, @UnknownSean8! Really great to see this taking shape 😊 Would you have interest in looking into #904 now that we have a component to easily slot this styling into?

@github-project-automation github-project-automation bot moved this from Todo to Done in activist Board Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants