Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat + refactor: added messenger sharing #1070

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

UnknownSean8
Copy link
Contributor

@UnknownSean8 UnknownSean8 commented Dec 19, 2024

Contributor checklist


Description

Refactored the buttons from the share page as a component and added messenger sharing to the modal. Lmk what do you think about the refactoring, thanks!

Related issue

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit 11cbd5d
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/676520e8ad51c10008e22640
😎 Deploy Preview https://deploy-preview-1070--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The changelog has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review December 19, 2024 23:24
@andrewtavis
Copy link
Member

Will pick this up and bring it in tomorrow morning, @UnknownSean8 :) If you have an idea on the failing frontend tests, then let us know. Specifically the type check errors in pages/organizations/[id]/events.vue.

@@ -27,7 +27,10 @@
/>
</div>
</HeaderAppPage>
<div v-if="organization.events?.length > 0" class="space-y-3 py-4">
<div
v-if="organization.events && organization.events.length > 0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was what I was thinking too, but also weird that it's not needed for groups 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mhm, I'll take a look at the groups later after work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's because the Events type was previously under the dom-events type by default, but since there is no default type for groups, it's defined as an any. The any type wouldn't have any problem under this case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, so we'll need to switch it up eventually. Thanks for checking that! 🚀

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much for the refactor and the frontend fixes, @UnknownSean8! Really great to have all of this so well structured :) Will make future work like #904 a lot easier 😊

@andrewtavis andrewtavis merged commit 829457d into activist-org:main Dec 20, 2024
7 checks passed
@UnknownSean8 UnknownSean8 deleted the feat/modal-share-page branch December 20, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants