Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share modal #1084

Closed
wants to merge 7 commits into from
Closed

Share modal #1084

wants to merge 7 commits into from

Conversation

Mahendradoak
Copy link
Contributor

Contributor checklist


Description

This pull request proposes changes to improve the social sharing functionality in the component. Specifically, it adds a "suggestions" feature that highlights suggested social media platforms. The key updates include:

New showSuggestions prop: This allows the component to conditionally display a suggestion note and icons next to specific social media buttons.
suggestedOptions array: A new array holds the names of suggested social media components (e.g., Telegram, Mastodon, Email, Signal), and these buttons are marked with a small suggestion icon when relevant.
Updated button components: Conditional rendering of the suggestion icon for the listed platforms.
Translation support: The note indicating suggested platforms is fully translatable.

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit 31685e1
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/67853054b2b9f3000831a2d2
😎 Deploy Preview https://deploy-preview-1084--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The changelog has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

Checking if you're planning to re-open this, @Mahendradoak :)

@Mahendradoak
Copy link
Contributor Author

Mahendradoak commented Jan 13, 2025 via email

@andrewtavis
Copy link
Member

But you're still planning on working on the issue?

@Mahendradoak
Copy link
Contributor Author

yes i am working on issue number #904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants