-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share modal #1084
Share modal #1084
Conversation
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
Checking if you're planning to re-open this, @Mahendradoak :) |
No, it was a mistake
…On Mon, Jan 13, 2025 at 6:56 PM Andrew Tavis McAllister < ***@***.***> wrote:
Checking if you're planning to re-open this, @Mahendradoak
<https://github.com/Mahendradoak> :)
—
Reply to this email directly, view it on GitHub
<#1084 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDFSWR37NICKFF5YFJ6N2NL2KQD55AVCNFSM6AAAAABVC3OC4GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBXHE2DSOJVHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
But you're still planning on working on the issue? |
yes i am working on issue number #904 |
Contributor checklist
Description
This pull request proposes changes to improve the social sharing functionality in the component. Specifically, it adds a "suggestions" feature that highlights suggested social media platforms. The key updates include:
New showSuggestions prop: This allows the component to conditionally display a suggestion note and icons next to specific social media buttons.
suggestedOptions array: A new array holds the names of suggested social media components (e.g., Telegram, Mastodon, Email, Signal), and these buttons are marked with a small suggestion icon when relevant.
Updated button components: Conditional rendering of the suggestion icon for the listed platforms.
Translation support: The note indicating suggested platforms is fully translatable.