Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy zcashd RPC tests and document how to run them #8779

Closed
arya2 opened this issue Aug 20, 2024 · 2 comments
Closed

Copy zcashd RPC tests and document how to run them #8779

arya2 opened this issue Aug 20, 2024 · 2 comments
Assignees
@oxarbitrage
Labels
A-compatibility Area: Compatibility with other nodes or wallets, or standard rules A-rpc Area: Remote Procedure Call interfaces C-testing Category: These are tests
Milestone
Zebra can replace...

Comments

@arya2
Copy link
Contributor

arya2 commented Aug 20, 2024 •
edited
Loading

Motivation

We want to improve Zebra's test coverage by running the zcashd RPC test framework with Zebra.

The first step is to move the tests into this repository, run them locally, document how to run them, and implement any basic infrastructure required to run them.

See: https://discord.com/channels/809218587167293450/1275444207368011778.
@arya2 arya2 added C-testing Category: These are tests A-rpc Area: Remote Procedure Call interfaces A-compatibility Area: Compatibility with other nodes or wallets, or standard rules labels Aug 20, 2024
@arya2 arya2 added this to the Zebra can replace `zcashd` milestone Aug 20, 2024
@arya2 arya2 changed the title Move zcashd RPC test framework and connect it to zebrad instead of zcashd Copy zcashd RPC tests here and document how to run them Aug 20, 2024
@arya2 arya2 changed the title Copy zcashd RPC tests here and document how to run them Copy zcashd RPC tests and document how to run them Aug 20, 2024
@arya2 arya2 mentioned this issue Aug 20, 2024
Open
6 tasks
@oxarbitrage oxarbitrage self-assigned this Sep 4, 2024
This was referenced Sep 4, 2024
Closed
Closed
@oxarbitrage oxarbitrage mentioned this issue Sep 16, 2024
Merged
7 tasks
@oxarbitrage
Copy link
Contributor

The following is a list with all the tests existing in the zcashd repository. The details of what RPC methods they call and what features are needed are detailed for each case (incomplete).
https://docs.google.com/spreadsheets/d/1F-KZuhGHvecpjzQ9PFeMLh8cJHaP8BxI3Kg0IWdBBuU

@mpguerra mpguerra mentioned this issue Sep 17, 2024
Open
@oxarbitrage
Copy link
Contributor

I think #8866 may have closed this even if we didn't moved all the tests but just some of them.

Closing in favor of #8781 where CI and further work could be done.

@mpguerra mpguerra closed this as not planned Won't fix, can't repro, duplicate, stale Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oxarbitrage oxarbitrage

Labels
A-compatibility Area: Compatibility with other nodes or wallets, or standard rules A-rpc Area: Remote Procedure Call interfaces C-testing Category: These are tests
Projects
Zebra
Archived in project
Milestone
Zebra can replace `zcashd`
Development

No branches or pull requests
3 participants
@mpguerra @arya2 @oxarbitrage